Git Product home page Git Product logo

Comments (7)

nicksnyder avatar nicksnyder commented on May 20, 2024

So HasFunc would return a boolean true/false if a translation exists or not?

from go-i18n.

mh-cbon avatar mh-cbon commented on May 20, 2024

yes. I also have been thinking to a sort of CascadeTFunc(Ids []string, args ...interface{}) string which has the advantage to better optimize the resources to find and identify the translation, see https://github.com/nicksnyder/go-i18n/blob/master/i18n/bundle/bundle.go#L224.

from go-i18n.

nicksnyder avatar nicksnyder commented on May 20, 2024

Couple questions:

Right now i m doing it by trying to translate each possibility until it returns non empty value which is considered as the translation to consume.
I d prefer to use a HasFunc(ID) to remove that test on empty response.

Tfunc should return the translation id, not an empty response if a translation doesn't exist. Can you share your code?

I also have been thinking to a sort of CascadeTFunc(Ids []string, args ...interface{}) string

If this function existed, would you still want/need HasFunc?

has the advantage to better optimize the resources to find and identify the translation

I don't quite see how there is a better way than checking the ids one by one in priority order.

from go-i18n.

mh-cbon avatar mh-cbon commented on May 20, 2024

1/ Right! mistake of mine.

func (f *FormTranslator) TError(formName string, fErr *FormValidationError) template.HTML {
  ids := []string{
    strings.ToLower(formName+"-"+fErr.Field+"-"+fErr.Tag),
    strings.ToLower(fErr.Ns+"-"+fErr.Tag),
    strings.ToLower(fErr.Field+"-"+fErr.Tag),
    strings.ToLower("form_error-"+fErr.Tag),
  }
  for _,id := range ids {
    m := f.T(id, fErr) //todo, escape fErr.Value.
    if m!="" && m!=id {
      return template.HTML(m)
    }
  }
  return template.HTML(f.missingTranslation(formName, fErr))
}

2/ If this function existed, would you still want/need HasFunc?

no

3/ there is this code that would be redundant.

4/ btw, language detection could be handled into TfuncAndLanguage, no ?

from go-i18n.

nicksnyder avatar nicksnyder commented on May 20, 2024

I think this will be solved/obsolete with v2 proposed in #92

from go-i18n.

mh-cbon avatar mh-cbon commented on May 20, 2024

sure, thanks.

from go-i18n.

nicksnyder avatar nicksnyder commented on May 20, 2024

I just tagged 2.0.0.beta.1. Please start using it and report any issues that you have.

from go-i18n.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.