Scrolling offset not considered about angular-novnc HOT 5 CLOSED

novnc/noVNC@77938ef - Page not found

Aha, my fault. I recall some changes in Util.getPosition that i made to work with fullscreen mode and scaling, so i can put code back and modify it for solve that problem.

FYI: There is no code which can fluently convert noVNC to angular-noVNC without a problems (If you do that, i'll buy you a beer =)) To be honest, i prefer that angular-noVNC stay on own libs stack based on current libs. Without people's needs i don't see any reasons to port everything new from original noVNC project, that can cause major harm to stability of application, except end-logic libs like des, base64 etc, of course. That's why we need active community and opened issues to improve the project in own way.

Thanks for your question.

from angular-novnc.

Oups sorry missed a letter: novnc/noVNC@c77938e

The related issue is novnc/noVNC#295

You choice is totally understandable, I agree that everything does not need to be backported directly from noVNC but for the underlying parts of angular-noVNC that relies directly on noVNC (like util.js) we might miss some usefull fix (like this one for example)

I might be wrong, but after a quick peek to lib/util.js for example it seems that you "just" wrapped it into an angular module. If yes maybe we could have a little build script to do that job... Or maybe its more complicated than just doing some wrapping ?

from angular-novnc.

Simple wrapper could help only to end-logic libs like des and base64. For example I changed the Util code, after add canvas scaling in to RFB and Input::Mouse, which can possible incompatible with vanilla noVNC Util. But i will think about that. It would be better to focus on writing a good tests for project, and do auto-wrapper scripts after that.

Most likely I will decide this issue(Scrolling offset) on this weekend.

Sorry, i have a really hard week (

from angular-novnc.

Ok, I get it.

There are weeks like that ... :) . No hurry, I (ugly) patched the code on my side with previous commit , I don't know if there is a better way ... but it works ...

If you have some todo list, and if I have the time (and the skills ) to do it, I would be glad to contribute !

from angular-novnc.

Okay I fixed it. Furthermore, I investigated the original noVNC project and found that, for example, Util.conf_default was replaced by Util.set_defaults. The application logic that uses a new method the same changed. That's mean that we cannot simply do ports from the noVNC. Or we may recreate angular-noVNC on current noVNC build.

If you really want to simplify ports you can communicate with noVNC author with:
a) They can create export format for modules, without a storing in global scope, so we can simply use to port a parts of application.
b) Freeze public modules methods names etc, for future portability.

This will be very helpful, because my English requires much more time for building correct sentences. Realy sorry for that.

from angular-novnc.