Comments (4)
@nickelser one important feature, for which docs are missing is the key
attribute in the options for concurrency. After reading through the code, I realized that it can be a Proc/Lamda, which totally worked for my use case (well, to a point, but the gem works as it should).
I did experience a problem with a Sidekiq backed job, which had named (not positional) parameters. The job would be called seemingly w/o parameters. I did change the signature of the perform method and got around it. Perhaps I should open another issue?
from activejob-traffic_control.
@psteininger I did try to document most things, sorry for the confusion!
I would love a PR, but barring that -- any details on what specifically was missing would be appreciated and I am happy to update!
from activejob-traffic_control.
@psteininger makes total sense -- I will add that to the docs. I also created a new issue to track the named arguments problem (#5), which I'll look at shortly (could definitely be an issue how we re-enqueue the jobs).
from activejob-traffic_control.
As with @nickelser, I had to read the source (and this issue) to realize the options for the key
parameter. I see the following options for Concurrency
key: nil,
wait_timeout: 0.1,
stale_timeout: 60 * 10
I think it would be helpful to document all of these. Either in rdoc or in the README (or both).
from activejob-traffic_control.
Related Issues (11)
- [Question] Stacking throttle? HOT 2
- Named arguments not passed correctly
- [Question/Suggestion] Replace instead of drop?
- Suo && unlock token HOT 1
- Suo::LockClientError HOT 3
- What license governs activejob-traffic_control?
- disable! & enable! job perpetually stuck
- Question: Where to put the initializer
- question: is concurrency per node or across all nodes working? HOT 1
- Usage with sidekiq HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from activejob-traffic_control.