Should have a limit to the amount of content to log about google-http-java-client HOT 6 CLOSED

Original comment by [email protected] on 18 Oct 2011 at 2:21

• Changed state: Accepted
• Added labels: Component-HTTP, Milestone-Version1.6.0, Priority-High
• Removed labels: Priority-Medium

from google-http-java-client.

Actually we already have setDisableContentLogging methods on HttpRequest and 
HttpResponse.  We might be able to instead convert that to a 
contentLoggingLimit, where 0 means don't log, and >0 means any size.

We might also want to avoid the confusing -1 idea, since I'm guessing even 
Integer.MAX_VALUE should be a more than reasonable upper bound.

Original comment by [email protected] on 18 Oct 2011 at 2:32

from google-http-java-client.

My 2c, is that either way, any code within "if (debugging) {}" should catch and 
sink exceptions, since they are incidental to the intention of the developer. 
Debugging should never change the behaviour of the app.

Original comment by [email protected] on 18 Oct 2011 at 3:57

from google-http-java-client.

Original comment by [email protected] on 28 Oct 2011 at 4:46

• Added labels: Milestone-Version1.7.0
• Removed labels: Milestone-Version1.6.0

from google-http-java-client.

http://codereview.appspot.com/5373102/

Original comment by [email protected] on 16 Nov 2011 at 4:01

• Changed state: Started

from google-http-java-client.

Original comment by [email protected] on 17 Nov 2011 at 3:36

• Changed state: Fixed

from google-http-java-client.