Code style? about psgitlab HOT 6 CLOSED

Sorry that the lack of consistency is keeping you from contributing. My goal is to make the barrier to entry small so more of the GitLab API is covered by more people. I don't have the time to produce all of the code in the module so it requires help. More hands means more inconsistency.

In this case, I'd welcome help with setting a standard and using technology to guide contributors as long as they are guidelines. Tests and Linting via PSScriptAnalyzer are as far as I'd like the project to go when it comes to requirements before merging.

I look forward to viewing your PR!

from psgitlab.

Interesting view. It makes sense to keep the barrier for entry low; this is one of the great things about PowerShell.

Personally the imposition of strict rules off-putting and is likely to result in me not engaging, unless there is extremely clear documentation on how to automatically format code after writing in our own style.

from psgitlab.

@robinmalik the formatting is pretty clear in that VSCode will format as expected since it is setup inside the branch of #208 and CI will complain if you skipped on formatting.

If you're using a different editor, I suggest you configure it once and commit it to the repo.
If you're using PowerShell ISE your out of luck 😆

from psgitlab.

Ok, if it's automated via CI then that's great! (also: VSCode ftw).

from psgitlab.

I agree. Humans should not care about formatting unless it prevents the readability.
Which in this case it does.
I had a tough time contributing to project without the changes looking like major refactoring because the code format made it hard to read and the code that had changed looked like gratuitous changes.

from psgitlab.

Thanks for tackling it @Casz. I go back and forth on mandating readability but I feel like I chose incorrectly years ago and now have to pay the price.

from psgitlab.