Comments (6)
Personally, I like what @pkozlowski-opensource did on pagination, but I would add more typing (even if it is not really needed). Like those number variables that are initialized but they don't have typing.
from ng-bootstrap.
Tests conventions:
I think we should write two big describe blocks. One to test the directive behavior (without UI) like we used to do with Angular 1 and then another big describe block to test the UI too.
What do you thing? We should do the same for all of them, so better if we lay some conventions.
from ng-bootstrap.
@Foxandxss you are raising many valid points here but IMO it would be easier to discuss those if we would have a separate issue for each point (and a label to find all those issues)
from ng-bootstrap.
What do you suggest? An issue for component conventions and another one for test conventions?
To be honest, I don't think one issue like this is too messy. We just need to settle some basic conventions between us so our component and tests follow the same ideas.
from ng-bootstrap.
What do you suggest?
One issue per item to discuss. I can see 4 separate issues here :-)
To be honest, I don't think one issue like this is too messy
I'm not saying it is messy - I'm just saying it would be far easier for me to focus on individual items rather that having a conversation about everything in one issue.
from ng-bootstrap.
Sure mate, will do that right now.
from ng-bootstrap.
Related Issues (20)
- ngbDropdown inside ngbNavLink causes error
- Feature request: expose componentRef in NgbModalRef HOT 1
- ngbAccordionCollapse does not collapse when ngbAccordionItem is disabled
- Accordion directive ignores Input Id
- Offcanvas is not dismissed, starts to stack HOT 1
- i am facing issue when i build the angular application HOT 2
- accordion prevent close (or open) of a item.
- Tooltip preventOverflow option HOT 2
- DatePICKER ISSUE OR BUG HOT 4
- Popover autoClose not dynamic HOT 4
- Users using a keyboard are unable to scroll down the modal when opened using arrow keys.
- ngb-offcanvas: container option not working HOT 5
- NgbDropdown using autoClose in template and dynamically changing it does not work HOT 4
- adding ngbNavLink cause all subsequent elements to be invisible HOT 1
- NgbDatePicker does not follow Internationalization format for firstDayOfWeek HOT 2
- Huge Bundle Size when import every module HOT 7
- NgbOffcanvasRef and NgbModalRef should expose a ComponentRef HOT 3
- close() should not trigger openChange, if invoked from ngOnDestroy
- ERROR NullInjectorError: R3InjectorError(AppModule)[NgbDropdown -> NgbDropdown]: NullInjectorError: No provider for NgbDropdown HOT 1
- [Bug] - Nested popover - autoclose="outside" not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ng-bootstrap.