Git Product home page Git Product logo

Comments (5)

drpatelh avatar drpatelh commented on July 28, 2024 1

As a result of the changes introduced in #109 we now have the ability to directly download Singularity containers, however, this functionality was added in an edge release i.e. 20.11.0-edge. This means I had to change the version of Nextflow we use for the module CI as shown in this commit. After the next stable Nextflow release we should revert the CI to using nxf_version: [<STABLE_RELEASE>, ""] again. Note the "" in that list will pull the latest stable release which at this point doesn't contain the functionality we need which is why I removed it in that commit.

from modules.

drpatelh avatar drpatelh commented on July 28, 2024

Good question 👍 Maybe we run against the first stable DSL2 release i.e. 20.07.1 as well as the latest? The pipeline CI tests do something similar but in this instance it ensures that the modules are working across the full spectrum of DSL2 releases. If we encounter breaking changes we can bump the minimum version used for the tests.

from modules.

drpatelh avatar drpatelh commented on July 28, 2024

Note the matrix tests will look something like this

from modules.

edmundmiller avatar edmundmiller commented on July 28, 2024

Gotcha! Thanks I couldn't find the right value for "latest"! I'll make another PR once #85 is merged.

from modules.

drpatelh avatar drpatelh commented on July 28, 2024

Hmmmm...after the recent (and superdooper) surge in modules and the failure of all of the current tests to be triggered with one NF version (due to Github Actions matrix limit of 256), I think testing multiple NF versions is overkill until something changes. At which point feel free to re-open this issue.

from modules.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.