Add Editor Config lint back in about modules HOT 6 CLOSED

The comments are breaking this

/*
 * Tidy up and join elements of a list to return a path string
 */

After running eclint fix on everything it still throws errors about invalid indent size: 1, expected: 0 on the block comments.

from modules.

Maybe this helps:
https://github.com/jedmao/eclint#support-for-doc-comments

from modules.

@grst Good catch!

Per jednano/eclint#226, eclint is no longer maintained.

https://github.com/editorconfig-checker/editorconfig-checker.javascript#readme is however, and it works with the comment blocks out of the box. PR incoming.

Something cool might be making a prettier plugin hooked up to the nf-core lint

from modules.

from modules.

Thanks guys! Those comments can be changed to support default options in editor linting tools by the way. Don't really use these normally so opinion neutral as to which one we go for. Ideally, something that has longevity.

from modules.

@grst I definitely prefer prettier myself. I was just getting at using it for all the linting would be cool (md, and yaml) and having a nextflow plugin! I was also hoping to avoid adding a .prettierrc to the project though, because I don't think the conversation has been had to possibly move yaml or md over. I don't think we should bother with it unless a nextflow-plugin is created. I'll look into it in a few weeks.

As I thought I can't find a way to just run editorconfig on files that don't have a parser with prettier.

from modules.