Git Product home page Git Product logo

Comments (5)

trvrb avatar trvrb commented on June 4, 2024

Thanks for note @alliblk. I just checked this on modular augur and the issue there is resolved. In this case, when aligning, you explicitly specify a Genbank reference to align to:

'--reference-sequence {input.ref} --fill-gaps'
. This results in the Genbank version overwriting the version passed in through the FASTA.

from augur.

tsibley avatar tsibley commented on June 4, 2024

I think if the input fasta contains the reference already then --reference-name should be used instead of --reference-sequence. It doesn't look like --reference-sequence overwrites anything, but merely appends the reference sequence to the input fasta: https://github.com/nextstrain/augur/blob/master/augur/align.py#L36-L46 ?

from augur.

trvrb avatar trvrb commented on June 4, 2024

@tsibley ---

Thanks for digging into this. I was assuming that it overwrote given that the resulting aligned.fasta just contained a single version of PF13/251013_18 and that this version was the right length. PF13/251013_18 was in the input sequences.fasta.

Perhaps the help for --reference-sequence could make it clearer that this expects a file (Genbank or FASTA).

from augur.

alliblk avatar alliblk commented on June 4, 2024

I haven't poked around modular augur yet, but glad to hear that it might fix this issue. That said, I'm wondering if it might be a good idea to also hardcode removal of the non-Troesemeier et al version of PF13/251013_18 during the prepare step, since this sequence seems so off.

from augur.

huddlej avatar huddlej commented on June 4, 2024

This issue seems to be resolved in the latest modular augur builds. The current Zika build uses choose_genbank for the download rule and uses the explicit --reference-sequence flag for the alignment rule. This results in the correct PF13/251013_18 sequence passing through the alignment stage and into the tree building stage.

from augur.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.