Git Product home page Git Product logo

Comments (4)

David-Development avatar David-Development commented on June 11, 2024 1

@hamuchen Thank you for the feedback.

A thought that comes to mind: If we allow zooming it would be counter intuitive with being able to scroll horizontally between articles. Imagine you are zooming in on something in the article and then you start scrolling horizontally because you want to go to the next article - you'd either have to scroll to the border of the article and trigger to get to the next page or zoom out completely. But then again.. it's the same awkward UX as e.g. WhatsApp has when you look at a bunch of pictures.

Should be fairly simple to implement - probably just need to adjust the following line:

news-android/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/async_tasks/RssItemToHtmlTask.java

Line 123 in cf83332

builder.append(String.format("<html dir=\"%s\"><head><meta name=\"viewport\" content=\"width=device-width, initial-scale=1, maximum-scale=1, minimum-scale=1, user-scalable=0\" />", rtlDir));

from news-android.

stefan-niedermann avatar stefan-niedermann commented on June 11, 2024 1

Hm, maybe it's possible to detect starting a pinch to zoom gesture (two fingures) and disable horizontal swiping in this case? When ending the pinch gesture, reenable horizontal swiping.

I remember a similar issue in the Notes app (vertical scrolling vs. swipe horizontal to delete) which had a similar "fix"

from news-android.

kuba-orlik avatar kuba-orlik commented on June 11, 2024 1

@David-Development

A thought that comes to mind: If we allow zooming it would be counter intuitive with being able to scroll horizontally between articles. Imagine you are zooming in on something in the article and then you start scrolling horizontally because you want to go to the next article - you'd either have to scroll to the border of the article and trigger to get to the next page or zoom out completely.

I remember looong time ago an iOS app that worked like this: if you pan the image right to left, and pan it to the absolute max, then the panning stops and there's this "there's nothing more to the right" animation effect on the right edge of the screen. But if you release your finger and then start swiping from right to left, then the image gives way and you can see the next news item slide in from the right.

But @hamuchen's suggestion to just have the ability to open the image standalone in fullscreen mode sounds much simpler to use (and possibly to implement, as well 🤞 )

from news-android.

hamuchen avatar hamuchen commented on June 11, 2024

Or you enable press / long press to open the image in a modal / fullscreen dialog where you can pinch to zoom?

from news-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.