Use the IP address of the user if userId is empty about forms HOT 8 CLOSED

The only real advantage I could see here is using a browser's footprint to store and make the "only one submission" option available for public views too. But this is far more complicated and not 100% foolproof. So I would close this indeed as out of scope :)

from forms.

I like your suggestion of using some identifier for unidentfied users.
I tried to apply your suggestion in my Nextcloud instance. My userId column is still empty.
There is no error in the log or anything. Am I missing something?

Another thought:
From a privacy point of view it would be more appropriate to store some hash of the RemoteIp since it contains already some information about the user (location, workplace, country...)

from forms.

I just tested again with the master branch and the IP address is displayed correctly in the Name column. I'm sending a pull request.

from forms.

seems this error is still not fixed?

Exception: Argument 2 passed to OCA\Forms\Db\NotificationMapper::findByUserAndForm() must be of the type string, null given, called in /var/www/cloud.offene-werkstaetten.org/apps/forms/lib/Controller/PageController.php on line 277

when i have a pbulic form, and share the link with a non logged-in user, i get a 500 Error.

from forms.

Things are mixed up here a bit.
The internal server Error itself is removed on master, just a release is pending.

The Proposal above is still open, but does not produce any Error if not implemented. Just an empty Name-Field in Results appears for unauthenticated users.

from forms.

@skjnldsv @jancborchardt John & me talked about this for a moment and store these users just like anonymous users now, as John said he wouldn't see any advantage of using the ip.
So the initial problem of an empty user here is solved. Is this issue to develop or just to close? ;)

from forms.

@jotoeri @skjnldsv I’d say if we have a different system which we consider better, we can close this? But your call :)

from forms.

how to do this?

from forms.