Git Product home page Git Product logo

Comments (3)

korelstar avatar korelstar commented on August 22, 2024 1

According to google, nobody uses l10n/ignorelist anymore:
https://www.google.de/search?q="l10n/ignorelist"+site:github.com
(yesterday, I removed it from the notes app: nextcloud/notes@3b55c48)

Hence, I think it's safe to remove the method readIgnoreList() from translationtool.php.

from docker-ci.

MorrisJobke avatar MorrisJobke commented on August 22, 2024

If I understand this correctly, /l10n/ignorelist was used by the old l10n.pl

Oh - actually I didn't knew that one 😧

and /.l10nignore is used by the new translationtool.php. Is this correct?

Correct. Just the file .l10nignore - one file per line and you are done.

Hence, the content of /l10n/ignorelist is totally ignored. If this is intended, we should remove the method readIgnoreList(). Otherwise (backward-compatibility?), the result of that method has to be used correctly.

Wow - actually I totally seemed to miss that. It's good to go.

Otherwise (backward-compatibility?), the result of that method has to be used correctly.

Is there actually using some app this? Because we now added those files to the apps we have in our transifex sync setup. If not I would say we should update the apps that still use the old way and go for that.

from docker-ci.

korelstar avatar korelstar commented on August 22, 2024

Is there actually using some app this? Because we now added those files to the apps we have in our transifex sync setup. If not I would say we should update the apps that still use the old way and go for that.

I don't know. I can't answer this, since I'm too far away from this. I don't even know if the old Perl script is still used somewhere (e.g. in nextcloud/server?). However, it looks like the new PHP script is used since 10 months and nobody has complained about it.

Finally, I think someone "official" from Nextcloud has to decide how to deal with this.

from docker-ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.