Git Product home page Git Product logo

Comments (14)

juliushaertl avatar juliushaertl commented on May 18, 2024 6

@joergmschulz I would prefer to keep the markdown description as a default and just use tabs for other stuff like the comments, just like it is handled in the files app.

2017-02-01-193228_511x404_scrot

from deck.

NebriBlackwing avatar NebriBlackwing commented on May 18, 2024 6

This seems pretty straight forward. @juliushaertl I'd be willing to give this a go. After reading this over it sounds like the majority wishes to see the comments as a tab under the details view that comes up on the right panel after clicking a card?

View screenshot below for how that comments tab would appear. Once you give me the go ahead I'll happily create a new branch for this issue and get to work. Been a long time since I last got to do any angularjs work!

image

from deck.

juliushaertl avatar juliushaertl commented on May 18, 2024 2

@laurentiu2 @JumpLink Comments and activity have actually gotten a high priority issue in the last month so I'm activly working on it right now. Expect a pull request soon. Both features will land in the next relase probably around end of september.

from deck.

NebriBlackwing avatar NebriBlackwing commented on May 18, 2024 2

@laurentiu2 I appreciate your kind words regarding my work on the REST api. I would like to also gently remind that juliushaertl has much more on his plate regarding deck. Typically Pull Requests are created when one of two things happen. We need feedback on the work in progress, or we believe the work is ready to be reviewed for a merge. Just because you haven't seen the pull request yet, doesn't mean there isn't a branch with the work being done yet. Patience my friends, together deck will continue to improve. :)

from deck.

juliushaertl avatar juliushaertl commented on May 18, 2024 1

Good point @jancborchardt We need to remind that for comments and activity #211

from deck.

joergmschulz avatar joergmschulz commented on May 18, 2024

I'm not sure how this could be done without cluttering the user interface. I like the simplicity of the current concept (well, dragging the cards would be a plus, you already opened an issue for this one) IMHO it is enough to have the description for the cards.

from deck.

jancborchardt avatar jancborchardt commented on May 18, 2024

Yup, very important for collaboration too. cc @blizzz for comments.

from deck.

blizzz avatar blizzz commented on May 18, 2024

Yes, it's possible to use comments in other apps. One example that does it is the announcement center app, related PRs: https://github.com/nextcloud/announcementcenter/pulls?q=is%3Apr+comment+is%3Aclosed

from deck.

juliushaertl avatar juliushaertl commented on May 18, 2024

Thanks for the hint.

from deck.

jancborchardt avatar jancborchardt commented on May 18, 2024

it sounds like the majority wishes to see the comments as a tab under the details view that comes up on the right panel after clicking a card?

Yes – just keep in mind that we also have a plan in the Files app to combine the chronological information (Activity, Comments, Versions) into one timeline. Not sure if anything else is chronological for now, but keep that in mind for the future @juliushaertl @Nebri :)

from deck.

JumpLink avatar JumpLink commented on May 18, 2024

@Nebri Do you want to implement this feature? Did you need help?

from deck.

NebriBlackwing avatar NebriBlackwing commented on May 18, 2024

@JumpLink No thank you, this is currently being handled by @juliushaertl . When I started commenting on this issue I had missed the fact that he is currently assigned to this task.

from deck.

laurentiu2 avatar laurentiu2 commented on May 18, 2024

this is currently being handled by @juliushaertl

and from nov 17, 2017 since Julius assigned himself, nothing happened! Wouldn't be better if Ryan handles this? btw awesome work on REST API :)

from deck.

JumpLink avatar JumpLink commented on May 18, 2024

Nce to hear, good luck!

from deck.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.