Adjust License Diff to account for License Category about deltacode HOT 19 CLOSED

You may want to break this up into small tickets if needed.

from deltacode.

@majurg @DennisClark I'm looking for several large codebases to test my license-change detection work and thought the recent Facebook change to its React licensing might be useful.

Testing react-16.0.0 against react-15.6.1, it appears from the DeltaCode output that the license in question might have the ScanCode key facebook-patent-rights-2 (category: Permissive). However, if I paste that key into a DejaCode Licenses search, the only license returned is antlr-pd.

• Is facebook-patent-rights-2 not listed in DejaCode, or (perhaps more likely) am I searching incorrectly?
• Assuming the license in question is in fact facebook-patent-rights-2, I'm curious why we treat it as Permissive when it created such an uproar.
• Last but not least, can you suggest one or two codebases in which there were changes from Permissive (or no license at all) to Copyleft Limited, Copyleft or some other more-restrictive license?

from deltacode.

@jmhoran once again, scancode is “ahead of” dejacode. Please create a new license request in DejaCode.

from deltacode.

@DennisClark Is that done by opening a new issue and assigning the label license_library?

from deltacode.

@johnmhoran that license may not be in DejaCode, or if it is, it is under a slightly different name.

As far as single projects that change from permissive to copyleft, I do not know many off the top of my head. You may have to craft these specific examples.

from deltacode.

@majurg Thanks -- will do. And thanks as well re how to create a license request.

from deltacode.

@majurg I'm in DejaCode -- is the license request submitted through the https://dejacode.zendesk.com/hc/en-us/requests/new URL (a "Submit a request" form)?

from deltacode.

No, go here: https://enterprise.dejacode.com/requests/

from deltacode.

Thanks @majurg -- request submitted.

from deltacode.

@majurg In one of your three examples above, 'permissive' -> 'copyleft limited or higher', how do you want to treat the delta if the old file has both 'permissive' and 'public domain'? They seem sufficiently similar in contrast to the 'copyleft limited or higher' group that I suggest we modify this to 'permissive' and/pr 'public domain' -> 'copyleft limited or higher'.

What do you think?

from deltacode.

FYI, I'm currently treating the following as comprising the categories of particular interest from among the license categories in DejaCode:

'Commercial'
'Copyleft'
'Copyleft Limited'
'Free Restricted'
'Patent License'
'Proprietary Free'

The remaining two categories are 'Permissive' and 'Public Domain'.

I'm interpreting 'copyleft limited or higher' as including all of the notable categories, and 'proprietary/commercial' as meaning 'Commercial' and 'Proprietary Free'. Let me know if this is not consistent with your intent.

from deltacode.

Yes, we should treat permissive and public domain the same.

we should "point out" (increase the score) all other cases.

from deltacode.

Thanks @majurg .

from deltacode.

@majurg Do we want to increase the score for each problematic license category that is added (e.g., one incremented score for 'Copyleft', no matter how many different licenses of this category are added), or increment for each unique license of a problematic category (e.g., 'gpl-2.0' and 'gpl-1.0-plus' ==> two score increments)? Thus far I've been taking the former approach.

from deltacode.

Your way is correct.

from deltacode.

👍

from deltacode.

@majurg I'm about to push a commit for your vetting -- more tests to follow.

from deltacode.

@majurg Push coming shortly. I've been able to substantially simplify the category-change detection while retaining all three of our new rules, i.e., incrementing Delta.score and supplementing Delta.factors when:

• no license ==> 'Copyleft Limited' or higher
• 'Permissive' or 'Public Domain' ==> 'Copyleft Limited' or higher
• anything ==> 'Proprietary Free' or 'Commercial'

For clarity, I've also added comments in the code indicating where each of these rules is implemented.

from deltacode.

merged #86, closing

from deltacode.