Git Product home page Git Product logo

Comments (2)

joliver avatar joliver commented on July 22, 2024

Yes, GetFrom would need a lock because the underlying "commits" variable is a List which is not guaranteed to be thread safe. This means that another thread could be modifying the list and appending values but the reader gets the values from the list while it's in a hybrid/unknown state which would result in undefined behavior. Even if this wasn't the case, the InMemoryPersistence is mostly for quick testing so I'm not too worried about an extra lock.

from neventstore.

danielmarbach avatar danielmarbach commented on July 22, 2024

Funny argumentation when all other methods are locking over either "commits", "undispatched", "snaptshots" or "heads". At least it would be consistent ;)

from neventstore.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.