[Suggestion] LAV Splitter Source: allow selecting smaller video resolution in multi-resolution HLS livestream about lavfilters HOT 1 OPEN

Update: today I recompiled LAV Filters myself from master and hacked this function into LAVSplitter, attached .zip contains my adjusted version:
https://nextcloud.dasdeck.com/index.php/s/bGPRdyxtXdAD7qL

There is only this single change: if there is a REG_DWORD value called "PreferredVideoStreamHeight" under HKCU\Software\LAV\Splitter, the demuxer will select the video stream with the smallest absolute difference to this value. If there is no such value in the registry, it will select the stream with the smallest difference to 4320 (=8K), so basically the same behavior as before, since I guess there are no HLS streams with higher resolution (but 4320 could also be replaced with 0xFFFFFFFF, so to really "always select the largest").

To make this work, I added this line on top of the programs for loop in method STDMETHODIMP CLAVFDemuxer::CreateStreams() in LAVFDemuxer.cpp:
DWORD dwFavoriteHeight = m_pSettings->GetPreferredVideoStreamHeight(); // CUSTOM

And inside the loop, I changed
//DWORD dwResolutionScore = st->codecpar->width * st->codecpar->height;
to
DWORD dwResolutionScore = 0xFFFFFFFF - (st->codecpar->height >= dwFavoriteHeight ? st->codecpar->height - dwFavoriteHeight : dwFavoriteHeight - st->codecpar->height);

And that's about it. New method "GetPreferredVideoStreamHeight" is declared in LAVSplitterSettingsInternal.h - since I didn't want to touch the public COM interface - and implemented in LAVSplitter.cpp like this:

STDMETHODIMP_(DWORD) CLAVSplitter::GetPreferredVideoStreamHeight()
{
    return m_settings.PreferredVideoStreamHeight;
}

And new DWORD property "PreferredVideoStreamHeight" of CLAVSplitter's Settings struct is initialized directly inside CLAVSplitter::LoadDefaults() like this:

    HRESULT hr;
    CRegistry reg = CRegistry(HKEY_CURRENT_USER, LAVF_REGISTRY_KEY, hr, TRUE);
    DWORD dwVal = reg.ReadDWORD(L"PreferredVideoStreamHeight", hr);
    if (SUCCEEDED(hr))
        m_settings.PreferredVideoStreamHeight = dwVal;
    else
        m_settings.PreferredVideoStreamHeight = 4320; // 8K

That's because I didn't want to recompile MPC-HC as well, so I wanted it to work also in case of m_bRuntimeConfig being true, and therefor couldn't add it to the ReadSettings method. For now it's just a hidden extra feature not showing up in the settings GUI, so only for those willing to edit stuff in the Registry. But that's perfectly fine for me.

from lavfilters.