Git Product home page Git Product logo

Comments (3)

OptimumCode avatar OptimumCode commented on June 19, 2024 1

I agree, without proper tests it would be hard to make sure nothing was broken. In this case, I think it is better to start from modifying JSON Schema Test suite - if new tests are accepted it should be easier to make changes in the related part of the code here. I will think about tests that can be added to the test suite to add additional coverage for Bidi rule

from json-schema-validator.

justin-tay avatar justin-tay commented on June 19, 2024

You're correct in that the implementation doesn't appear to be particularly accurate with regards to RFC5893. There are so few test cases in the JSON Schema Test Suite that I'm not sure if any fixes applied would be correct. I think the accurate reference is probably icu4j but it's a 13mb dependency.

from json-schema-validator.

stevehu avatar stevehu commented on June 19, 2024

Closing this issue until the Official Test Suite is upgraded.

from json-schema-validator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.