Comments (7)
To verify this issue I setup a GoCommerce single-tenant instance on Heroku and set GOCOMMERCE_SMTP_ADMIN_EMAIL
to my custom email address.
When ordering I verified that these mails were sent:
- Order confirmation to customer - sent from my admin email
- Order notification to admin email - sent from my admin email
@pukhalski could you check if this is still happening for you and otherwise close this issue?
from gocommerce.
I dont see GOCOMMERCE_MAILER_ADMIN_EMAIL
in the configuration types. Is it implemented?
I do see SMTP_ADMIN_EMAIL thought.
from gocommerce.
You are right. GOCOMMERCE_MAILER_ADMIN_EMAIL
is not available.
But GOCOMMERCE_SMTP_ADMIN_EMAIL
is the one that's supposed to work which I verified.
from gocommerce.
Are these settings that should be moved to the settings.json file rather than the addon instance configuration / ENV var configuration? @mraerino and or @biilmann perhaps you have insight here.
from gocommerce.
For Netlify Identity / GoTrue this is also kept in the instance config.
I don't see any reason why this should be configured in the shop site.
from gocommerce.
I think you're right.
from gocommerce.
@pukhalski Not sure where GOCOMMERCE_MAILER_ADMIN_EMAIL
is coming from. Can you give me a pointer? Sounds like this issue is working with the ENV var so this should be good to close. If we have additional issues with the addons parameters, or the other MAILER_ADMIN_EMAIL setting we should open a separate issues.
from gocommerce.
Related Issues (20)
- TBD and remaining issues HOT 2
- Install TLS certificate in GoCommerce instance HOT 3
- Bad pagination parameters HOT 1
- Database error on reports/products HOT 1
- Automate migration
- Indexes in postgresql are not namespaced HOT 1
- Make payment providers optional HOT 1
- No downloads returned. HOT 2
- Support Strong Customer Authentication using stripe HOT 3
- Rip out netlify-commons HOT 1
- transactions list endpoint fails with SQL error
- Invalid http body on /claim endpoint
- Placing an order with multiple digital products allows to download only files for the first added
- Fix invalid paypal transaction updates
- Fix intermittently failing test: TestOrderCreate/MultipleItemsWithDownloads
- How can I use it ? HOT 3
- not working on heroku it show something error in code HOT 2
- [security] Enforce Branch Protections
- BUG - Error douring deploy on Heroku by button
- Different pricing based on user role
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gocommerce.