Git Product home page Git Product logo

Comments (7)

mraerino avatar mraerino commented on May 21, 2024

To verify this issue I setup a GoCommerce single-tenant instance on Heroku and set GOCOMMERCE_SMTP_ADMIN_EMAIL to my custom email address.

When ordering I verified that these mails were sent:

  • Order confirmation to customer - sent from my admin email
  • Order notification to admin email - sent from my admin email

@pukhalski could you check if this is still happening for you and otherwise close this issue?

from gocommerce.

bcomnes avatar bcomnes commented on May 21, 2024

I dont see GOCOMMERCE_MAILER_ADMIN_EMAIL in the configuration types. Is it implemented?

I do see SMTP_ADMIN_EMAIL thought.

from gocommerce.

mraerino avatar mraerino commented on May 21, 2024

You are right. GOCOMMERCE_MAILER_ADMIN_EMAIL is not available.

But GOCOMMERCE_SMTP_ADMIN_EMAIL is the one that's supposed to work which I verified.

from gocommerce.

bcomnes avatar bcomnes commented on May 21, 2024

Are these settings that should be moved to the settings.json file rather than the addon instance configuration / ENV var configuration? @mraerino and or @biilmann perhaps you have insight here.

from gocommerce.

mraerino avatar mraerino commented on May 21, 2024

For Netlify Identity / GoTrue this is also kept in the instance config.
I don't see any reason why this should be configured in the shop site.

from gocommerce.

bcomnes avatar bcomnes commented on May 21, 2024

I think you're right.

from gocommerce.

bcomnes avatar bcomnes commented on May 21, 2024

@pukhalski Not sure where GOCOMMERCE_MAILER_ADMIN_EMAIL is coming from. Can you give me a pointer? Sounds like this issue is working with the ENV var so this should be good to close. If we have additional issues with the addons parameters, or the other MAILER_ADMIN_EMAIL setting we should open a separate issues.

from gocommerce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.