@tjtjtjtj-tw If you look carefully, it might be that the building of the ptools library failed. Would you like to cd to ptools dir and see if you can make it successfully there?

from vmaf.

Dear li-zhi,

I see there is a libptools.so successfully built.
ptool directory is built using Makefile.VMAF.

So... am I wrong with something?
I don't know if Cygwin + Makefile.VMAF in ptool directory is supposed to be used or not.

Thank you.

from vmaf.

The error message from make is:

make[1]: Entering directory '/home/tjtjtjtj/vmaf-master/wrapper'
g++ -o vmafossexec /home/tjtjtjtj/vmaf-master/wrapper/obj/alloc.o /home/tjtjtjtj/vmaf-master/wrapper/obj/file_io.o /home/tjtjtjtj/vmaf-master/wrapper/obj/cpu.o /home/tjtjtjtj/vmaf-master/wrapper/obj/convolution.o /home/tjtjtjtj/vmaf-master/wrapper/obj/convolution_avx.o /home/tjtjtjtj/vmaf-master/wrapper/obj/adm.o /home/tjtjtjtj/vmaf-master/wrapper/obj/adm_tools.o /home/tjtjtjtj/vmaf-master/wrapper/obj/ansnr.o /home/tjtjtjtj/vmaf-master/wrapper/obj/ansnr_tools.o /home/tjtjtjtj/vmaf-master/wrapper/obj/vif.o /home/tjtjtjtj/vmaf-master/wrapper/obj/vif_tools.o /home/tjtjtjtj/vmaf-master/wrapper/obj/motion.o /home/tjtjtjtj/vmaf-master/wrapper/obj/psnr.o /home/tjtjtjtj/vmaf-master/wrapper/obj/math_utils.o /home/tjtjtjtj/vmaf-master/wrapper/obj/convolve.o /home/tjtjtjtj/vmaf-master/wrapper/obj/decimate.o /home/tjtjtjtj/vmaf-master/wrapper/obj/ssim_tools.o /home/tjtjtjtj/vmaf-master/wrapper/obj/ssim.o /home/tjtjtjtj/vmaf-master/wrapper/obj/ms_ssim.o /home/tjtjtjtj/vmaf-master/wrapper/obj/svm.o /home/tjtjtjtj/vmaf-master/wrapper/obj/combo.o /home/tjtjtjtj/vmaf-master/wrapper/obj/vmaf.o /home/tjtjtjtj/vmaf-master/wrapper/obj/darray.o /home/tjtjtjtj/vmaf-master/wrapper/obj/main.o /home/tjtjtjtj/vmaf-master/wrapper/obj/pugixml.o -L/home/tjtjtjtj/vmaf-master/wrapper/../ptools -lm -lpthread -lptools -Wl,-rpath=/home/tjtjtjtj/vmaf-master/wrapper/../ptools

/usr/lib/gcc/x86_64-pc-cygwin/5.4.0/../../../../x86_64-pc-cygwin/bin/ld: cannot find -lptools

collect2: Error：ld return 1
make[1]: *** [Makefile:129: vmafossexec] Error 1
make[1]: Leaving directory '/home/tjtjtjtj/vmaf-master/wrapper'

from vmaf.

If I remember correctly someone had a similar issue with lptools on Linux that ended up being caused by Windows style line endings (based on how they cloned the repo). Since you are having a similar issue on Cygwin I wonder if this is a similar issue. Can you try to run dos2unix on the entire checkout? (Or change your git settings to preserve the original line endings). I wonder if that would make a difference.

from vmaf.

@cosmin
I tried to dos2unix everything hierarchically under vmaf-master/ptool as well as vmaf-master/wrapper, and this doesn't make any difference.
The problem remains.
However, thank you anyway.

from vmaf.

@tjtjtjtj-tw It's probably related to wrapper/Makefile. I have this switch:

vmafossexec: $(OBJS)
ifeq ($(shell uname),Darwin)
$(CXX) -o $@ $(LDFLAGS) $^ -L$(PTOOLSDIR) $(LIBS) -Wl
else
$(CXX) -o $@ $(LDFLAGS) $^ -L$(PTOOLSDIR) $(LIBS) -Wl,-rpath=$(PTOOLSDIR)
endif

It detects the OS version (Darwin is for mac os) and run differently to build vmafossexec. I don't know what's the correct way for cygwin, you can probably try it out.

(Also in ptools, there is another switch:

libptools : $(COM_OBJS)
ifeq ($(shell uname),Darwin)
$(CC) $(CCFLAGS) $(COM_OBJS) -dynamiclib -install_name $(shell pwd)/libptools.dylib -o libptools.dylib
else
$(CC) $(CCFLAGS) $(COM_OBJS) -shared -o libptools.so
endif

here libptools.dylib is for mac os and libptools.so is for linux/debian only(?)

)

from vmaf.

The settings for Mac doesn't work correctly in Cygwin.
The problem remains.

from vmaf.

@li-zhi @cosmin
Dear all,

I do a modification for Makefile in ptool directory for Cygwin.
The libptools is supposed to be a shared library (libptools.so in Linux and libptools.dylib in Mac OS) originally .
I added one line to create a static library "libptools.a".
Then the vmafossexec.exe is successfully created. (However it is a 6737898-byte executable. XD )

Change from:
=======Original Makefile(in ptools directory) begin=======
libptools : $(COM_OBJS)
ifeq ($(shell uname),Darwin)
$(CC) $(CCFLAGS) $(COM_OBJS) -dynamiclib -install_name $(shell pwd)/libptools.dylib -o libptools.dylib
else
$(CC) $(CCFLAGS) $(COM_OBJS) -shared -o libptools.so
endif
=======Original Makefile(in ptools directory) end=======

Change to:
=======Modified Makefile(in ptools directory) begin=======
libptools : $(COM_OBJS)
ifeq ($(shell uname),Darwin)
$(CC) $(CCFLAGS) $(COM_OBJS) -dynamiclib -install_name $(shell pwd)/libptools.dylib -o libptools.dylib
else
$(CC) $(CCFLAGS) $(COM_OBJS) -shared -o libptools.so

ar rcs libptools.a $(COM_OBJS)

endif
=======Modified Makefile(in ptools directory) end=======

from vmaf.

I am not an expert in makefile writing so it is kind if anyone familiar with it can commit the modification for Cygwin properly.

I summarize the change need to be applied to let vmaf be created successfully in Cygwin :

1. Add "-D_GNU_SOURCE" to CXXFLAGS in vmaf-master/wrapper/Makefile to let several C++ source file compile successfully.
2. Add "ar rcs libptools.a $(COM_OBJS)" in vmaf-master/ptools/Makefile to create a static library "libptools.a".

from vmaf.

@tjtjtjtj-tw Thanks for the suggestion. Please keep this thread open so that I (or someone else) could pick it up later.

from vmaf.

i have same problem
what exactly means
Add "-D_GNU_SOURCE" to CXXFLAGS in vmaf-master/wrapper/Makefile to let several C++ source file compile successfully.
where i should add "-D_GNU_SOURCE" ?

from vmaf.