Errors and sentinels included in JSON message post-deserialization about falcor HOT 10 CLOSED

Checked the state of the response from the server and it looks good.

from falcor.

Up early or stayed up late?

Jafar is there any way we can simplify this and turn it into a unit test?

from falcor.

Already working on it.

JH

On Apr 10, 2015, at 8:04 AM, Michael Paulson [email protected] wrote:

Up early or stayed up late?

Jafar is there any way we can simplify this and turn it into a unit test?

—
Reply to this email directly or view it on GitHub.

from falcor.

@jhusain i have finished the unit test.
@trxcllnt this bug is happening during merge as PathMap. I have uploaded 2 unit tests with similar bugs.
Here is the PR #76

from falcor.

This is supercritical. It's blocking us from engaging with external partners like angular.

from falcor.

I have updated the unit test to have a specific core test for this that covers all the points.

from falcor.

Issued PR #1 to Michael's fork.

from falcor.

Moving note from PR to here:

@trxcllnt i merged without considering error. We have to stop testing on Node 12 until we...

1. figure out why pointing to a github url does not work in npm v2
2. stop testing npm v2 / node 12 until we open source.

side note: coverage has tanked since this PR. don't forget to unit test your new methods.

from falcor.

@michaelbpaulson there are unit tests, but they're commented out until the get portion of #66 is resolved.

from falcor.

Fixed in #90.

from falcor.