aminate exits with "successful termination" when provisioning fails about aminator HOT 5 CLOSED

Here is the simplest "solution":

diff --git a/aminator/core.py b/aminator/core.py
index f73f9cf..5c22709 100644
--- a/aminator/core.py
+++ b/aminator/core.py
@@ -55,7 +55,7 @@ class Aminator(object):

     def aminate(self):
         with self.environment(self.config, self.plugin_manager) as env:
-            error = env.provision()
+            error = not env.provision()
             if not error:
                 log.info('Amination complete!')
         return error
diff --git a/aminator/environment.py b/aminator/environment.py
index b3288ea..e4c927e 100644
--- a/aminator/environment.py
+++ b/aminator/environment.py
@@ -56,7 +56,7 @@ class Environment(object):
                     if not success:
                         log.critical('Finalizing failed!')
                         return False
-        return None
+        return True

     def __enter__(self):
         return self

But that feels kind of icky.

from aminator.

Augh, that is entirely my fault again--documentation for sys.exit, of course, says success on 0 or None and says 'any other object' will result in a status code of 1.

The intention was to have whatever the success value was from the environment get passed on down through the stack to sys.exit. If everything succeeded, sys.exit would get None, if there was a failure, sys.exit would get False. sys.exit, it seems, actually returns a status code of 1 for a value of true of all things, so the above code will possibly cause the overall process to fail when it really succeeded:

% python -c 'import sys; sys.exit(True)'; echo $?
1

% python -c 'import sys; sys.exit(None)'; echo $?
0

% python -c 'import sys; sys.exit(False)'; echo $?
0

% python -c 'import sys; sys.exit("banana")'; echo $?
banana
1

The easiest way to fix that? Each of the checks in the context managers:

                    if not success:
                        log.critical('Finalizing failed!')
                        return False

for example, need to return True.

So, given

    def provision(self):
        [...]
                        success = provisioner.provision()
                        if not success:
                            log.critical('Provisioning failed!')
                            return True
                    success = finalizer.finalize()
                    if not success:
                        log.critical('Finalizing failed!')
                        return True
        return None

This

    def aminate(self):
        with self.environment(self.config, self.plugin_manager) as env:
            error = env.provision()
            if not error:
                log.info('Amination complete!')
        return error

has error = True on failure, Amination complete will get logged on success, error is None if success, True if failure, and as we saw, sys.exit(True) is a failed execution. All is right with the world.

from aminator.

That said, for readability's sake, it probably makes a bit more sense to use some kind of value that will clearly indicate failure but doesn't require one to build truth tables to sort out because of funky logic inversion :)

from aminator.

Does this:
08a47de

Resolve this issue?

from aminator.

Yeah, I think it is fixed. Thanks Peter.
-Cory

from aminator.