Comments (9)
For the data-wp-page-cookie
this needs to be linked with #12
from cn-website.
The proposed approach we discussed was leveraging the global and page metadata to achieve this, so authors can easily inject the props and update those if needed.
And then we take a few lines of JS to replicate the meta props on the body or main element.
Only exception would be the cookie value as @mhaack pointed out
from cn-website.
Could you align those infos with the dataLayer Analytics uses? @verlok please talk to Mauricio if there are such values already available there. Especially data-wp-page-type smells like something Analytics would need too.
from cn-website.
Draft instrumentation on the main div here: https://github.com/hlxsites/netcentric/tree/72-data-attributes-live-ux
See on https://72-data-attributes-live-ux--netcentric--hlxsites.hlx.page/drafts/mblanche/who-we-are.
from cn-website.
Thanks @meryllblanchet, that works!
Would you be able to update it also on the 404 page, or is it something we need to do on NC's side?
from cn-website.
Also @meryllblanchet can you please open a PR?
from cn-website.
@meryllblanchet? The golive is tomorrow at 3PM, can you open a PR?
from cn-website.
Hello @verlok , apologies for having missed you here. Will raise a PR tomorrow morning as I am also adding the support for the 404 html.
Let's sync-up on Slack, I will briefly show you the setup on the authoring side.
from cn-website.
Actually @verlok , I updated the PR that has been opened by @mhaack . Please check #143.
from cn-website.
Related Issues (20)
- CDN: Brotli Compression
- Blog Overview missing middle Blog in 3 on Logistics page HOT 3
- Blog Overview button goes to wrong page HOT 1
- JS: The Creation of Elements
- Default link color
- Spike - Franklin Sidekick Library HOT 2
- Improve Desktop Lighthouse Score HOT 1
- Removing comma from Leader Block
- Low quality images on Leader Profiles block
- Multicolor accordion - button color
- BUG: Blog Post Page Sidebar - Multiple Authors Not Showing HOT 1
- Social Media block needs new font colour on hover HOT 1
- BUG: Series of pdfs (Bernstien articles) cannot be downloaded HOT 6
- Setting pages to noindex later won't remove them from search
- BUG: share button from https://www.netcentric.biz/jobs is not working
- BUG MOBILE: Jobs descriptions text are cut
- BUG: Icons not displayed correctly under Benefits of Working at Cognizant Netcentric
- New Requirement: Add optional field for "last updated date" in the published articles pages
- Long Term Solution: Job Description
- Franklin Sidekick Library - Implementation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cn-website.