Git Product home page Git Product logo

Comments (9)

mhaack avatar mhaack commented on September 22, 2024 2

For the data-wp-page-cookie this needs to be linked with #12

from cn-website.

ramboz avatar ramboz commented on September 22, 2024

The proposed approach we discussed was leveraging the global and page metadata to achieve this, so authors can easily inject the props and update those if needed.

And then we take a few lines of JS to replicate the meta props on the body or main element.

Only exception would be the cookie value as @mhaack pointed out

from cn-website.

nc-andreashaller avatar nc-andreashaller commented on September 22, 2024

Could you align those infos with the dataLayer Analytics uses? @verlok please talk to Mauricio if there are such values already available there. Especially data-wp-page-type smells like something Analytics would need too.

from cn-website.

meryllblanchet avatar meryllblanchet commented on September 22, 2024

Draft instrumentation on the main div here: https://github.com/hlxsites/netcentric/tree/72-data-attributes-live-ux
See on https://72-data-attributes-live-ux--netcentric--hlxsites.hlx.page/drafts/mblanche/who-we-are.

from cn-website.

verlok-cn avatar verlok-cn commented on September 22, 2024

Thanks @meryllblanchet, that works!

Would you be able to update it also on the 404 page, or is it something we need to do on NC's side?

from cn-website.

verlok-cn avatar verlok-cn commented on September 22, 2024

Also @meryllblanchet can you please open a PR?

from cn-website.

verlok-cn avatar verlok-cn commented on September 22, 2024

@meryllblanchet? The golive is tomorrow at 3PM, can you open a PR?

from cn-website.

meryllblanchet avatar meryllblanchet commented on September 22, 2024

Hello @verlok , apologies for having missed you here. Will raise a PR tomorrow morning as I am also adding the support for the 404 html.
Let's sync-up on Slack, I will briefly show you the setup on the authoring side.

from cn-website.

meryllblanchet avatar meryllblanchet commented on September 22, 2024

Actually @verlok , I updated the PR that has been opened by @mhaack . Please check #143.

from cn-website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.