Git Product home page Git Product logo

Comments (8)

bashleigh avatar bashleigh commented on June 18, 2024 1

I 'think' (not tried this) you can do this

order: {
   'userId': 'DESC',
   'photoName': 'DESC',
}

Might want to check typeorm docs https://typeorm.io/#/select-query-builder/adding-order-by-expression

from nestjs-typeorm-paginate.

AnhLy-zz avatar AnhLy-zz commented on June 18, 2024 1

I can sort by creating a query builder likes:

createQueryBuilder("photo")
    .innerJoin("photo.userId", "user")
    .orderBy("user.name")
    .getMany();


But in this case, I use paginate which could not write like this:
    return paginate<Photo>(this.photoRepository,
      { page, limit },
      { order: { "user.name": "DESC" } },
    );

Any solutions to these issues? Thank you very much.

from nestjs-typeorm-paginate.

bashleigh avatar bashleigh commented on June 18, 2024 1

@AnhLy new feature 😂 I'll add it in and release :p I've added it in but need tests

from nestjs-typeorm-paginate.

AnhLy-zz avatar AnhLy-zz commented on June 18, 2024

Thanks for your response, but I want to sort user name follow the alphabet, instead of userId.

from nestjs-typeorm-paginate.

bashleigh avatar bashleigh commented on June 18, 2024

Ok, after looking at the typeorm types it looks like this is not possible. Below you can see that the order object has to have a key that relates to the entity.

order?: {
     [P in keyof Entity]?: "ASC" | "DESC" | 1 | -1;
 };

In your case you don't really want to be using the repository, you probably want to be using the query builder. So I propose we add a new paginate method that will accept the queryBuilder (one method that takes queryBuilder || repository). This will enable you to do the above.

asyncf function paginate<Entity>(repoOrQueryBuilder: QueryBuilder | Repository<Entity>): Promise<Pagination<Entity>> {
   // check if repo or query builder 
  // return result
}

Type wise we'll end up with 2 defined methods

async function paginate<Entity>(repository: Repository<Entity>, options: IPaginationOptions, searchOptions: FindConditions<Entity> | FindManyOptions<Entity>): Proimse<Pagination<Entity>>;

async function paginate<Entity>(queryBuilder: QueryBuilder, options: IPaginationOptions): Promise<Entity>;

from nestjs-typeorm-paginate.

AnhLy-zz avatar AnhLy-zz commented on June 18, 2024

Thanks for taking the answer, here is the source code of the paginate, https://github.com/nestjsx/nestjs-typeorm-paginate/blob/master/src/paginate.ts, the paginate only receive the repository: Repository param. Or I miss something?

from nestjs-typeorm-paginate.

AnhLy-zz avatar AnhLy-zz commented on June 18, 2024

@bashleigh Oh thank you very very much.

from nestjs-typeorm-paginate.

bashleigh avatar bashleigh commented on June 18, 2024

will release in next version :)

from nestjs-typeorm-paginate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.