Cached responses 200 -> 304 about terminus HOT 6 CLOSED

Thanks for you report! I personally don't think it's a good idea to add this to Terminus directly. I think @Header('Cache-Control', 'no-store') is the way to go as you've described. Though I think wouldn't hurt to update the documentation.

I'm open to change my mind though if other people face the same issue and had to do the same workaround?

from terminus.

Yeah it's one to understand where the responsibility of the cache is owned at this point.

My argument for adding it to Terminus (as a condition to turn on and off cache: false/true, by default no caching enabled) is that you wrap your route in the @HealthCheck() decorator. When doing a health check you want the actual results vs cached results.

Use case being that if you're doing checks in Kubernetes or other deployment methods/services that allow for health checking you want to know real time that the service is up and not some old out dated previous cached result that maybe during that time you ran out of memory, database crashed etc.

from terminus.

I had this issue too and had to use the work around.

from terminus.

After further considerations I have implemented this feature #2335

from terminus.

Released with v10.1.0 🎉

from terminus.

Thanks @BrunnerLivio !

from terminus.