Git Product home page Git Product logo

Comments (4)

Sturgelose avatar Sturgelose commented on April 28, 2024 4

@kamilmysliwiec just saw your related issue :)
I found out that we can pass a parameter to Passport to expose the ExecutionContext :)

Using super({ passReqToCallback: true }); in the class, enables to see the request (it's a parameter from PassportJS). From there, we can read parameters from the URL, queries, and many other things :)

@Injectable()
export class BearerStrategy extends PassportStrategy(Strategy) {
  constructor(
    private readonly authService: AuthService,
    private readonly tokenService: AccessTokenService,
  ) {
    // passReqToCallback allows to have the request in the validate() function
    super({ passReqToCallback: true });
  }

  /**
   * Function to check that a given token is valid
   * @param request
   * @param token Token to be validated
   * @param done Callback when finished
   * @returns {Promise<any>}
   */
  async validate(request: IncomingMessage, token: string, done) {
    // Fetch a user by a token
    const user = await this.authService.validateToken(token);

    // No matching user found or Token Expired
    if (!user) {
      return done(new UnauthorizedException(), false);
    }

    const allowAccess = await this.authService.validateACL(user.id, request);
    allowAccess ? done(null, user) : done(new UnauthorizedException(), false);
  }
}

from passport.

Sturgelose avatar Sturgelose commented on April 28, 2024 4

Ok, after some more research, it's not possible to add the nestjs context into the passportjs context. The reason is that passport expects a request object, nothing else.

Finally I used a different approach: use the nestjs/passport module to do authentication. This module sets the user value back in the response object in the context.
Then in a second guard, I do authorization, using the precalculated user data in the previous guard.

This now works as expected ;)

from passport.

Sturgelose avatar Sturgelose commented on April 28, 2024 1

Hi, another update. Seems the only context exposed is the HTTP one. In order to use reflectors, this would need the original context. So still, this wouldn't be possible to be fixed with the solution I found. The best solution would be to expose by default the whole context in the validate function, instead of the incoming message

from passport.

kamilmysliwiec avatar kamilmysliwiec commented on April 28, 2024

Use the nestjs/passport module to do authentication. This module sets the user value back in the response object in the context. Then in a second guard, I do authorization, using the precalculated user data in the previous guard.

This ^ solution sounds like the best possible one 🙂

from passport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.