Call resolve on error about passport HOT 12 CLOSED

You're absolutely right! Thank you for pointing me at this issue :) Fixed in 5.0.2

from passport.

I think the problem is that when you put an unknown strategy into AuthGuard (e.g. @UseGuards(AuthGuard('whatever'))) it won't complain.

from passport.

Hi. Was this really fixed? I have followed the guide and got the same error, I am using Nest 5.8.0.

from passport.

Maybe something like this:

const createPassportContext = (request, response) => (type, options, callback) => new Promise((resolve, reject) => {
    const next = (value) => {
        console.log('here we go', value);
        return value instanceof Error ? reject(value) : resolve(value);
    }
    return passport.authenticate(type, options, (err, user, info) => {
        try {
            request.authInfo = info;
            return resolve(callback(err, user, info));
        }
        catch (err) {
            reject(err);
        }
    })(request, response, next)
});

When I do this I get a 500 error, that make much more sense...

from passport.

Please, provide a repository which reproduces your issue.
And resolve has to be used, it's not an issue.

from passport.

Simply follow this tutorial https://docs.nestjs.com/techniques/authentication step by step :-D

from passport.

but actually, you can also try there https://github.com/apiel/wudo
cd backend && yarn && yarn start

http://localhost:3000/users

You will get the response [1234] when you should not be authorize

from passport.

I just pulled your repo and everything works well. I'm getting 401 when the token is not passed through the network, same as expected.

from passport.

Yes because in the mid-time, I have been working on it... As @DEX3 described, change @UseGuards(AuthGuard('bearer'))) to @UseGuards(AuthGuard('whatever'))) you will then get no error and have access to the entry point.

Also, can you explain me why you are resolving error? Shouldn't error be rejected in a promise?

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise#Parameters

executor
A function that is passed with the arguments resolve and reject. The executor function is executed immediately by the Promise implementation, passing resolve and reject functions (the executor is called before the Promise constructor even returns the created object). The resolve and reject functions, when called, resolve or reject the promise, respectively. The executor normally initiates some asynchronous work, and then, once that completes, either calls the resolve function to resolve the promise or else rejects it if an error occurred. If an error is thrown in the executor function, the promise is rejected. The return value of the executor is ignored.

from passport.

change @UseGuards(AuthGuard('bearer'))) to @UseGuards(AuthGuard('whatever'))) you will then get no error and have access to the entry point

The responsibility for checking whether a strategy exists belongs to passport library (that's why we cannot detect it earlier).

Also, can you explain me why you are resolving error? Shouldn't error be rejected in a promise?

Because the resolved value is eventually passed to the handleRequest method anyway. See:

from passport.

If I remember correctly, resolve(new error...) is called before handleRequest and handleRequest is not called. You should really try to replace @UseGuards(AuthGuard('bearer'))) to @UseGuards(AuthGuard('whatever'))) , you will understand.

from passport.

Close it ;)

from passport.