Common class that extends AuthGuard(DynamicType) about passport HOT 7 CLOSED

I guess i can also say this is due to issue #21
https://github.com/nestjs/passport/issues/21

from passport.

Another thing i would like to note is that I tried to use an interceptor for common logic but it was not executing (as expected?)

    @Get('login/azure')
    @UseGuards(AuthGuard('azure'))
    @UseInterceptors(PassportLoginInterceptor)
    @ApiOperation({title: 'Handles the azure login'})
    public loginAzure() {
        return {};
    }

from passport.

Please, provide a minimal repository which reproduces your issue.

from passport.

Here's an example repo:
https://github.com/boenrobot/nestjs-issues/tree/master/auth-guard-nondry

I have a different use case, but same request...

I want to invert the way auth guards are applied - have all routes protected by default, except those featuring a custom decorator called @Public. I can do that, but adding support for it is done per authentication strategy, which means lots of duplicated code, and one more thing to remember doing if a new auth method is added.

In the example, I've added two local strategies, but you can imagine an app with various other auth methods (Google, Facebook, etc.). The files with duplicated code are public-aware-auth-local-primary.guard.ts and public-aware-auth-local-secondary.guard.ts.

from passport.

Would you like to create PR for this issue?

from passport.

There is no enough bandwidth to fix this issue.

from passport.

I thought you might like this.

controller

type Provider = 'google' | 'facebook';

@Controller()
export class AuthController {
  @Get(':provider')
  @UseGuards(OauthGuard)
  public async googleOauth(@Param() provider: Provider) {
    Logger.log(`${provider} login`);
  }
}

guard

@Injectable()
export class OauthGuard implements CanActivate {
  canActivate(
    context: ExecutionContext,
  ): boolean | Promise<boolean> | Observable<boolean> {
    const { provider } = context.switchToHttp().getRequest().params;

    const Guard = AuthGuard(provider);

    return new Guard('google').canActivate(context);
  }
}

from passport.