Git Product home page Git Product logo

Comments (4)

boenrobot avatar boenrobot commented on April 28, 2024

I think this would be addressed if #117 is merged.

The "workaround" (then legit) code would be like:

       this.samlStrategy.getPassportInstance().logout(req, function (err, req) {
            if (!err) {
                res.send('<h1>Logout Failure!!</h1>');
            }
        });

from passport.

ricardosaracino avatar ricardosaracino commented on April 28, 2024

I actually have a minimal repo for this one

https://github.com/ricardosaracino/nestjs-sp/blob/master/src/auth/auth.controller.ts

    @Get('logout')
    @UseGuards(SessionGuard)
    @ApiOperation({title: 'Initiates the SAML logout flow'})
    public logout(@Req() req, @Res() res) {
        (this.samlStrategy as any).logout(req, (err, request) => {
            if (!err) {
                res.redirect(request);
            }
        });
    }

from passport.

kamilmysliwiec avatar kamilmysliwiec commented on April 28, 2024

#117 has been merged and published as 6.2.0

from passport.

brandon-leapyear avatar brandon-leapyear commented on April 28, 2024

I'm not sure how #117 fixes this issue. This issue is about using methods on the Strategy instance, not about using a global/local Passport instance

from passport.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.