Comments (6)
I started to work on @configuration
For now I have something like this:
Decorator:
import 'reflect-metadata';
import {ConfigurationMetadata} from '../../interfaces/configuration-metadata.interface';
import {isNil, isObject} from '../shared.utils';
import {FILE_METADATA, IN_MEMORY_METADATA, URL_METADATA} from '../../constants';
export const Configuration = (metadata?: ConfigurationMetadata): ClassDecorator => {
return isObject(metadata) ? ConfigurationFrom(metadata) : InMemoryConfiguration();
};
const InMemoryConfiguration = (): ClassDecorator => {
return (target: object) => {
Reflect.defineMetadata(IN_MEMORY_METADATA, true, target);
}
};
const ConfigurationFrom = (metadata: ConfigurationMetadata): ClassDecorator => {
if (!isNil(metadata.file))
return FileConfiguration(metadata.file);
else if (!isNil(metadata.url))
return RemoteConfiguration(metadata.url);
};
const FileConfiguration = (filename: string): ClassDecorator => {
return (target: object) => {
Reflect.defineMetadata(FILE_METADATA, filename, target);
}
};
const RemoteConfiguration = (url: string): ClassDecorator => {
return (target: object) => {
Reflect.defineMetadata(URL_METADATA, url, target);
}
};
Helper classes:
export interface IConfiguration {
getProperty(name: string): string;
}
export abstract class AbstractConfiguration implements IConfiguration {
constructor(protected properties: {[key: string]: string} = {}) {}
public getProperty(name: string): string {
return this.properties[name];
}
}
export abstract class AbstractInMemoryConfiguration extends AbstractConfiguration{
constructor() {
super();
this.declare();
}
protected abstract declare(): void;
}
And a use case:
class TestConfiguration extends AbstractInMemoryConfiguration {
protected declare(): void {
this.properties['KEY'] = 'VALUE';
}
}
Regarding the @configuration decorator I can declare it like this:
@Configuration()
class TestConfiguration extends AbstractInMemoryConfiguration { }
@Configuration(file: 'filename')
class TestConfiguration extends AbstractFileConfiguration { }
@Configuration(url: 'http://domain/path')
class TestConfiguration extends AbstractRemoteConfiguration { }
Does it seem to be good for you guys ?
from nest.
Are you sure we really need the abstraction layer over configuration stuff? I think now it's easy to fetch the remote configuration / load config using fs package just before creating the Nest instance. If the configuration affects components and should be a part of the DI container - just use async components. What @thomrick proposed looks really good, but I'm trying to keep in mind that learning curve is already big enough 😃
from nest.
Hi @thomrick,
Thank you so much for the invested time, but I just don't want to exaggerate. Maybe in the future, but not now 🙂 Kamil
from nest.
@kamilmysliwiec could you leave it open? It's very nice feature.
from nest.
You convinced me.
from nest.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from nest.
Related Issues (20)
- Supply time to TypeOrmLogger.logQuery() HOT 1
- TCP.onStreamRead (node:internal/stream_base_commons:217:20) HOT 1
- RabbitMQ Bug Microservices HOT 1
- nx 18 + nest + webpack + serverless breaking with error src/main.handler is undefined or not exported HOT 1
- NestJS doesn't handle "Operation failed: QueueDeclare" error from amqplib HOT 1
- Problems Encountered with NestJS and pnpm in a Monorepo Setup HOT 1
- grpc microservice stops listening to requests after version 10.3.3 (needs peer dependency) HOT 1
- perf: caching return value for some functions HOT 1
- The request body does not return an object whose value is an array of objects
- Jest spy doesn't work on Microservices Controller (EventPattern) E2E Tests
- Feature Request: Support for Bun.js HOT 2
- Multi-tenant app fail on first non durable tree request HOT 2
- Kafka Microservice Error When Consumer Has Not Joined the Consumer Group
- LoggerService transforms the instance of Error when controller throws an Error HOT 3
- Easy way to compose ORed validators HOT 1
- Not sure if it is bug or feature request, nest middleware in jest runs before any other express middleware HOT 2
- Devtools with microservices: Error: listen EADDRINUSE: address already in use :::8000 HOT 4
- Hooks in global module which imported more than twice might called multiple times HOT 2
- Overide providers from imported module (not in testing context) HOT 5
- Nest crash when RouteConstraints is used without app versioning enabled HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nest.