Comments (10)
uWebSockets should be better than socket.io, IMO
from nest.
Socket.io is familiar to most of the Angular community of which Nest has it's roots. I don't disagree that uWebSockets outperforms socket.io at scale but imo Nest shouldn't make choices like that for consumers.
As @ProbablePrime said above, make it pluggable, support what makes sense & allow consumers to make their own tooling choices.
from nest.
Hi @ProbablePrime,
Since 3.0.0
you can create adapter for any ws library. Read more
from nest.
@kamilmysliwiec I don't think this addresses the issue.
The issue is asking for a way to replace Socket.io completely. Right now this appears to just require an adapter to return Socket.io instances. It would still require the whole Socket.io interface on the object returned from createWithNamespace
from nest.
@cojack, yes 😃
from nest.
Hi @ProbablePrime,
Since latest update you should be able to use custom socket.io adapter. Example:
import { SocketIoAdapter } from '@nestjs/common';
class CustomAdapter implements SocketIoAdapter {
create(port: number) {
return {};
}
createWithNamespace(port: number, namespace: string) {
return {};
}
}
const app = NestFactory.create(ApplicationModule, instance);
app.setIoAdapter(new CustomAdapter());
from nest.
@kamilmysliwiec will be this #80 pr merged in a few days?
from nest.
This looks a lot better \o/ thanks! doing a more indepth read of your changes but i will close it most likely
from nest.
Yep PERFECT. thanks!
from nest.
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from nest.
Related Issues (20)
- nx 18 + nest + webpack + serverless breaking with error src/main.handler is undefined or not exported HOT 1
- NestJS doesn't handle "Operation failed: QueueDeclare" error from amqplib HOT 1
- Problems Encountered with NestJS and pnpm in a Monorepo Setup HOT 1
- grpc microservice stops listening to requests after version 10.3.3 (needs peer dependency) HOT 1
- perf: caching return value for some functions HOT 1
- The request body does not return an object whose value is an array of objects
- Jest spy doesn't work on Microservices Controller (EventPattern) E2E Tests
- Feature Request: Support for Bun.js HOT 2
- Multi-tenant app fail on first non durable tree request HOT 2
- Kafka Microservice Error When Consumer Has Not Joined the Consumer Group
- LoggerService transforms the instance of Error when controller throws an Error HOT 3
- Easy way to compose ORed validators HOT 1
- Not sure if it is bug or feature request, nest middleware in jest runs before any other express middleware HOT 2
- Devtools with microservices: Error: listen EADDRINUSE: address already in use :::8000 HOT 4
- Hooks in global module which imported more than twice might called multiple times HOT 2
- Overide providers from imported module (not in testing context) HOT 5
- Nest crash when RouteConstraints is used without app versioning enabled HOT 2
- NestJS Mongoose populate() Not Working for Arrays of ObjectIds, But Works for Single ObjectId HOT 4
- Problem with File upload in Swagger HOT 1
- @fastify/view version in @nestjs/platform-fastify needs to be updated HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nest.