Git Product home page Git Product logo

Comments (3)

tabs-not-spaces avatar tabs-not-spaces commented on May 2, 2024

Doing this now, but even if we include rowKeyValue into the create function, the static createEntity in https://github.com/nestjs/azure-database/blob/master/lib/table-storage/azure-table.mapper.ts#L36 needs to be updated as well, yes? otherwise it's just going to replace rowKeyValue with a GUID...

from azure-database.

tabs-not-spaces avatar tabs-not-spaces commented on May 2, 2024

my other thought was simply modifying

static createEntity<D>(partialDto: Partial<AzureEntityMapper>, rowKeyValue = generateUuid()) {
to

static createEntity(partialDto, rowKeyValue) {

and updating

entityDescriptor.RowKey._ = rowKeyValue;
to:

 if (null == partialDto.RowKey) {
      entityDescriptor.RowKey._ = rowKeyValue
  }
  else {
      entityDescriptor.RowKey._  = partialDto.RowKey;
  }

This way, we can define a RowKey in the entity / DTO which will take precedence, or if we don't implicitly define a RowKey a GUID will be created.


Update: looks like we were both on the same correct path - there were a few extra changes required. Submitting PR now :)

from azure-database.

manekinekko avatar manekinekko commented on May 2, 2024

closed in 070bad3

from azure-database.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.