Git Product home page Git Product logo

Comments (48)

GFoniX avatar GFoniX commented on August 22, 2024 15

I apologize once again, the issue stems from the fact that I added a "transporters" verification system. In the code, I used console.error instead of console.log for the validation. So, if you see "Transporter is ready", it will still work, but it will be displayed in red instead of green. The fix is currently being validated and will likely be published soon #1133.

For those whose CI/CD is affected by this, I invite you, as explained by @AmruthPillai, to downgrade to version 1.10.3. To do this, simply execute this command:

npm install @nestjs-modules/[email protected] -s

Once again, sorry for any inconvenience caused. The fix should be validated soon.

from mailer.

Mjeevanantham avatar Mjeevanantham commented on August 22, 2024 11

Path: lib/mailer.service.ts

private verifyTransporter(transporter: Transporter, name?: string): void {
const transporterName = name ? '${name}' : '';
transporter.verify()
.then(() => this.mailerLogger.error(Transporter${transporterName} is ready))

  • ❌ .then(() => this.mailerLogger.error(Transporter${transporterName} is ready))
    change it to
  • ✅.then(() => this.mailerLogger.log(Transporter${transporterName} is ready))

image

Output:
image

from mailer.

gterras avatar gterras commented on August 22, 2024 11

This seems fixed in 2.0.2, thanks!

from mailer.

dotoleeoak avatar dotoleeoak commented on August 22, 2024 7

d6480e3
It seems the issue is fixed by this commit, but it has not released yet. Maybe we just have to wait for the next release.

from mailer.

vincentayorinde avatar vincentayorinde commented on August 22, 2024 5

my version: "@nestjs-modules/mailer": "^1.11.2",

I fixed it this way
Path: node_modules/@nestjs-modules/mailer/dist/mailer.service.js

I changed
then(() => this.mailerLogger.error(Transporter${transporterName} is ready))
to
then(() => this.mailerLogger.log(Transporter${transporterName} is ready))

from mailer.

matissePe avatar matissePe commented on August 22, 2024 3

Hello, when will the new version be released ?

from mailer.

jaequery avatar jaequery commented on August 22, 2024 3

although this seems like a minor "logging information" issue, this is actually breaking the the pipelines for many CI/CD deployment practices

from mailer.

Ben-Avrahami avatar Ben-Avrahami commented on August 22, 2024 3

i get the same error on the latest release for now (v 2.0.0)

from mailer.

jaequery avatar jaequery commented on August 22, 2024 2

@GFoniX It's all good and fine, we all make mistakes and we appreciate your efforts.

from mailer.

jaequery avatar jaequery commented on August 22, 2024 2

the fix is a one-liner. why would it take so long for approval?

from mailer.

sieeniu avatar sieeniu commented on August 22, 2024 1

I have the same issue... I've seen you fixed it, but when it would be released?

from mailer.

bodva avatar bodva commented on August 22, 2024 1

@jaequery it was not included in the release 1.11.2
You can check the diff here:
v1.11.0...v1.11.2
We all waiting for the release with the fix.

from mailer.

GFoniX avatar GFoniX commented on August 22, 2024 1

@AbdulRahman-Sharief @joaodematejr @xxwangkaimin
It's just an error of the type of log. It's currently working. The PR is currently in review

from mailer.

AdiMarianMutu avatar AdiMarianMutu commented on August 22, 2024 1

I'm having the same issue and this is breaking our CI/CD Pipeline as well.

v1.11.2

from mailer.

AdiMarianMutu avatar AdiMarianMutu commented on August 22, 2024 1

my version: "@nestjs-modules/mailer": "^1.11.2",

I fixed it this way Path: node_modules/@nestjs-modules/mailer/dist/mailer.service.js

I changed then(() => this.mailerLogger.error(Transporter${transporterName} is ready)) to then(() => this.mailerLogger.log(Transporter${transporterName} is ready))

It is better to downgrade or to wait for a fix as monkey patching is never a good solution.

from mailer.

Maetes avatar Maetes commented on August 22, 2024 1

I would appreciate a new release too. @juandav can you say something when you will be releasing it?

from mailer.

levialkalidamat avatar levialkalidamat commented on August 22, 2024 1

I didn't pull the latest changes, but I believe it has. I was following a related PR that I believe got merged

I just tested sending email just now and I still get the same error. how to fix this error thanks from PR

from mailer.

TheSizkarn avatar TheSizkarn commented on August 22, 2024

I have exactly this too.

from mailer.

jaequery avatar jaequery commented on August 22, 2024

This is preventing my CI/CD to pass. When will this be released?

from mailer.

zguiyang avatar zguiyang commented on August 22, 2024

I have exactly this too.

from mailer.

jarcoder avatar jarcoder commented on August 22, 2024

I have this too. Trying to connect to the Gmail

from mailer.

jaequery avatar jaequery commented on August 22, 2024

FYI, i'm on the latest (v1.11.2) and i get the same error. which is weird because it looks like the fix was released to v1.11.2. not sure what's going on.

from mailer.

matissePe avatar matissePe commented on August 22, 2024

You are right, that's weird

from mailer.

tranhuywin avatar tranhuywin commented on August 22, 2024

I am experiencing the same issue and I believe it should be resolved urgently

from mailer.

maidasii avatar maidasii commented on August 22, 2024

I also encountered this issue and subsequently adjusted the version of @nestjs-modules/mailer in the package.json to 1.10.3, explicitly omitting the caret (^) prefix. However, it seems that the problem began to manifest from this version onward. Fortunately, the connection is successful, albeit the error message generated is quite perplexing.

from mailer.

GFoniX avatar GFoniX commented on August 22, 2024

Fixed in this PR #1133.

from mailer.

bodva avatar bodva commented on August 22, 2024

@GFoniX it is not related to the sendgrid error, the fix for this issue, merged before. We all waiting for the release of that fix.

from mailer.

jaequery avatar jaequery commented on August 22, 2024

what is the blocker for this release?

from mailer.

xxwangkaimin avatar xxwangkaimin commented on August 22, 2024

image
My project also encountered this issue after it was released

from mailer.

joaodematejr avatar joaodematejr commented on August 22, 2024

same problem :(

from mailer.

AbdulRahman-Sharief avatar AbdulRahman-Sharief commented on August 22, 2024

email
I have the same problem...

from mailer.

Mjeevanantham avatar Mjeevanantham commented on August 22, 2024

Debugger listening on ws://127.0.0.1:51567/b0316a6c-674f-4ca8-b364-b2d65aff7cdd
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
Debugger listening on ws://127.0.0.1:51572/2973334e-c38f-47e1-87a9-a207c324e876
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [NestFactory] Starting Nest application...
[2024-03-21 06:36:02] DEBUG Creating transport: nodemailer (6.9.12; +https://nodemailer.com/; SMTP/6.9.12[client:6.9.12])
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [InstanceLoader] MailerModule dependencies initialized +26ms
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [InstanceLoader] MailerCoreModule dependencies initialized +1ms
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [InstanceLoader] AppModule dependencies initialized +1ms
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [RoutesResolver] AppController {/}: +11ms
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [RouterExplorer] Mapped {/, GET} route +7ms
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [NestApplication] Nest application successfully started +6ms
[2024-03-21 06:36:02] DEBUG [ly7gcXw5biE] Resolved smtp.gmail.com as 142.251.10.109 [cache miss]
[2024-03-21 06:36:02] INFO [ly7gcXw5biE] Secure connection established to 142.251.10.109:465
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 220 smtp.gmail.com ESMTP q18-20020aa79832000000b006e6c04efd9dsm12778050pfl.206 - gsmtp
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] C: EHLO [127.0.0.1]
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-smtp.gmail.com at your service, [.151.72]
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-SIZE 35882577
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-8BITMIME
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-AUTH LOGIN PLAIN XOAUTH2 PLAIN-CLIENTTOKEN OAUTHBEARER XOAUTH
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-ENHANCEDSTATUSCODES
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-PIPELINING
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-CHUNKING
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250 SMTPUTF8
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] SMTP handshake finished
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] C: AUTH PLAIN =
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 235 2.7.0 Accepted
[2024-03-21 06:36:03] INFO [ly7gcXw5biE] User "
*******@gmail.com" authenticated
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] C: QUIT
[Nest] 11912 - 21/03/2024, 12:06:03 pm ERROR [MailerService] Transporter is ready
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 221 2.0.0 closing connection q18-20020aa79832000000b006e6c04efd9dsm12778050pfl.206 - gsmtp
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] Closing connection to the server using "end"
[2024-03-21 06:36:03] INFO [ly7gcXw5biE] Connection closed

same issue for me too But it is not an error, it is a information

from mailer.

maxbronnikov10 avatar maxbronnikov10 commented on August 22, 2024

+ for issue. wait for hotfix

from mailer.

YaroslavPuntus avatar YaroslavPuntus commented on August 22, 2024

Do we have information about when this bug will be fixed?

from mailer.

ABIKEM01 avatar ABIKEM01 commented on August 22, 2024

Please I am having this same issue and its breaking my deployment.

from mailer.

AmruthPillai avatar AmruthPillai commented on August 22, 2024

Right now, the only option is to stick to v1.10.3 unless there's some changes in v1.11.x that you absolutely need (unlikely).

from mailer.

saumil-palm avatar saumil-palm commented on August 22, 2024

hello i have v1.10.3 it's still show me the error
Screenshot 2024-03-27 at 11 39 39 AM

from mailer.

AmruthPillai avatar AmruthPillai commented on August 22, 2024

@saumil-palm If you were on v1.11.x earlier and just changed the package.json to reflect v1.10.3, chances are that npm/pnpm/yarn is just using the latest cached version.

You need to pin the version to a specific number, so in package.json, remove the "^" in front of the version. Also, it helps to remove all node modules and just re-pull all dependencies again to ensure the latest version hasn't been cached.

from mailer.

saumil-palm avatar saumil-palm commented on August 22, 2024

@AmruthPillai thank you for suggestions.
@AmruthPillai i had updated to version ^1.3.22 and still got the error so
I removed the code that using mailer.

from mailer.

rhernandez-itemsoft avatar rhernandez-itemsoft commented on August 22, 2024

It is not exactly an error. But they must correct the code.
image

from mailer.

Nurudeeen avatar Nurudeeen commented on August 22, 2024

I had the same issue, fixed it by removing the "^" symbol from the version number in my package.json file and re-installing the version of the mailer package through "yarn install" (i am using yarn)

Screenshot 2024-04-02 at 7 41 57 AM Screenshot 2024-04-02 at 7 42 36 AM

from mailer.

bodva avatar bodva commented on August 22, 2024

does anyone know why the fix can be released?

from mailer.

anthonyyoussef01 avatar anthonyyoussef01 commented on August 22, 2024

I have the same issue

my version: "@nestjs-modules/mailer": "^1.11.2",

I fixed it this way Path: node_modules/@nestjs-modules/mailer/dist/mailer.service.js

I changed then(() => this.mailerLogger.error(Transporter${transporterName} is ready)) to then(() => this.mailerLogger.log(Transporter${transporterName} is ready))

Why can't this be part of a pr and release? Seems trivial, though I haven't spent much time looking into this

from mailer.

gterras avatar gterras commented on August 22, 2024

This package is not suitable (anymore ?) for production, it has been continuously broken in a way or another for the last two years we've been using it.

No hard feelings for the maintainers who do as much as they can, and thanks for their hard work, but now it's pretty clear everyone using this package for serious matter should look for an alternative.

from mailer.

matissePe avatar matissePe commented on August 22, 2024

Is there a process to allow new maintainers ?

from mailer.

levialkalidamat avatar levialkalidamat commented on August 22, 2024

please has the problem been resolved?

from mailer.

anthonyyoussef01 avatar anthonyyoussef01 commented on August 22, 2024

I didn't pull the latest changes, but I believe it has. I was following a related PR that I believe got merged

from mailer.

bodva avatar bodva commented on August 22, 2024

the same here

from mailer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.