Comments (48)
I apologize once again, the issue stems from the fact that I added a "transporters" verification system. In the code, I used console.error instead of console.log for the validation. So, if you see "Transporter is ready", it will still work, but it will be displayed in red instead of green. The fix is currently being validated and will likely be published soon #1133.
For those whose CI/CD is affected by this, I invite you, as explained by @AmruthPillai, to downgrade to version 1.10.3. To do this, simply execute this command:
npm install @nestjs-modules/[email protected] -s
Once again, sorry for any inconvenience caused. The fix should be validated soon.
from mailer.
Path: lib/mailer.service.ts
private verifyTransporter(transporter: Transporter, name?: string): void {
const transporterName = name ? '${name}'
: '';
transporter.verify()
.then(() => this.mailerLogger.error(Transporter${transporterName} is ready
))
- ❌ .then(() => this.mailerLogger.error(
Transporter${transporterName} is ready
))
change it to - ✅.then(() => this.mailerLogger.log(
Transporter${transporterName} is ready
))
from mailer.
This seems fixed in 2.0.2, thanks!
from mailer.
d6480e3
It seems the issue is fixed by this commit, but it has not released yet. Maybe we just have to wait for the next release.
from mailer.
my version: "@nestjs-modules/mailer": "^1.11.2",
I fixed it this way
Path: node_modules/@nestjs-modules/mailer/dist/mailer.service.js
I changed
then(() => this.mailerLogger.error(
Transporter${transporterName} is ready))
to
then(() => this.mailerLogger.log(
Transporter${transporterName} is ready))
from mailer.
Hello, when will the new version be released ?
from mailer.
although this seems like a minor "logging information" issue, this is actually breaking the the pipelines for many CI/CD deployment practices
from mailer.
i get the same error on the latest release for now (v 2.0.0)
from mailer.
@GFoniX It's all good and fine, we all make mistakes and we appreciate your efforts.
from mailer.
the fix is a one-liner. why would it take so long for approval?
from mailer.
I have the same issue... I've seen you fixed it, but when it would be released?
from mailer.
@jaequery it was not included in the release 1.11.2
You can check the diff here:
v1.11.0...v1.11.2
We all waiting for the release with the fix.
from mailer.
@AbdulRahman-Sharief @joaodematejr @xxwangkaimin
It's just an error of the type of log. It's currently working. The PR is currently in review
from mailer.
I'm having the same issue and this is breaking our CI/CD Pipeline as well.
v1.11.2
from mailer.
my version:
"@nestjs-modules/mailer": "^1.11.2",
I fixed it this way Path:
node_modules/@nestjs-modules/mailer/dist/mailer.service.js
I changed
then(() => this.mailerLogger.error(
Transporter${transporterName} is ready))
tothen(() => this.mailerLogger.log(
Transporter${transporterName} is ready))
It is better to downgrade or to wait for a fix as monkey patching is never a good solution.
from mailer.
I would appreciate a new release too. @juandav can you say something when you will be releasing it?
from mailer.
I didn't pull the latest changes, but I believe it has. I was following a related PR that I believe got merged
I just tested sending email just now and I still get the same error. how to fix this error thanks from PR
from mailer.
I have exactly this too.
from mailer.
This is preventing my CI/CD to pass. When will this be released?
from mailer.
I have exactly this too.
from mailer.
I have this too. Trying to connect to the Gmail
from mailer.
FYI, i'm on the latest (v1.11.2) and i get the same error. which is weird because it looks like the fix was released to v1.11.2. not sure what's going on.
from mailer.
You are right, that's weird
from mailer.
I am experiencing the same issue and I believe it should be resolved urgently
from mailer.
I also encountered this issue and subsequently adjusted the version of @nestjs-modules/mailer
in the package.json to 1.10.3
, explicitly omitting the caret (^) prefix
. However, it seems that the problem began to manifest from this version onward. Fortunately, the connection is successful, albeit the error message generated is quite perplexing.
from mailer.
Fixed in this PR #1133.
from mailer.
@GFoniX it is not related to the sendgrid error, the fix for this issue, merged before. We all waiting for the release of that fix.
from mailer.
what is the blocker for this release?
from mailer.
My project also encountered this issue after it was released
from mailer.
same problem :(
from mailer.
from mailer.
Debugger listening on ws://127.0.0.1:51567/b0316a6c-674f-4ca8-b364-b2d65aff7cdd
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
Debugger listening on ws://127.0.0.1:51572/2973334e-c38f-47e1-87a9-a207c324e876
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [NestFactory] Starting Nest application...
[2024-03-21 06:36:02] DEBUG Creating transport: nodemailer (6.9.12; +https://nodemailer.com/; SMTP/6.9.12[client:6.9.12])
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [InstanceLoader] MailerModule dependencies initialized +26ms
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [InstanceLoader] MailerCoreModule dependencies initialized +1ms
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [InstanceLoader] AppModule dependencies initialized +1ms
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [RoutesResolver] AppController {/}: +11ms
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [RouterExplorer] Mapped {/, GET} route +7ms
[Nest] 11912 - 21/03/2024, 12:06:02 pm LOG [NestApplication] Nest application successfully started +6ms
[2024-03-21 06:36:02] DEBUG [ly7gcXw5biE] Resolved smtp.gmail.com as 142.251.10.109 [cache miss]
[2024-03-21 06:36:02] INFO [ly7gcXw5biE] Secure connection established to 142.251.10.109:465
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 220 smtp.gmail.com ESMTP q18-20020aa79832000000b006e6c04efd9dsm12778050pfl.206 - gsmtp
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] C: EHLO [127.0.0.1]
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-smtp.gmail.com at your service, [.151.72]
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-SIZE 35882577
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-8BITMIME
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-AUTH LOGIN PLAIN XOAUTH2 PLAIN-CLIENTTOKEN OAUTHBEARER XOAUTH
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-ENHANCEDSTATUSCODES
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-PIPELINING
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250-CHUNKING
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 250 SMTPUTF8
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] SMTP handshake finished
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] C: AUTH PLAIN =
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 235 2.7.0 Accepted
[2024-03-21 06:36:03] INFO [ly7gcXw5biE] User "*******@gmail.com" authenticated
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] C: QUIT
[Nest] 11912 - 21/03/2024, 12:06:03 pm ERROR [MailerService] Transporter is ready
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] S: 221 2.0.0 closing connection q18-20020aa79832000000b006e6c04efd9dsm12778050pfl.206 - gsmtp
[2024-03-21 06:36:03] DEBUG [ly7gcXw5biE] Closing connection to the server using "end"
[2024-03-21 06:36:03] INFO [ly7gcXw5biE] Connection closed
same issue for me too But it is not an error, it is a information
from mailer.
+ for issue. wait for hotfix
from mailer.
Do we have information about when this bug will be fixed?
from mailer.
Please I am having this same issue and its breaking my deployment.
from mailer.
Right now, the only option is to stick to v1.10.3
unless there's some changes in v1.11.x
that you absolutely need (unlikely).
from mailer.
hello i have v1.10.3 it's still show me the error
from mailer.
@saumil-palm If you were on v1.11.x earlier and just changed the package.json to reflect v1.10.3, chances are that npm/pnpm/yarn is just using the latest cached version.
You need to pin the version to a specific number, so in package.json, remove the "^" in front of the version. Also, it helps to remove all node modules and just re-pull all dependencies again to ensure the latest version hasn't been cached.
from mailer.
@AmruthPillai thank you for suggestions.
@AmruthPillai i had updated to version ^1.3.22 and still got the error so
I removed the code that using mailer.
from mailer.
It is not exactly an error. But they must correct the code.
from mailer.
I had the same issue, fixed it by removing the "^" symbol from the version number in my package.json file and re-installing the version of the mailer package through "yarn install" (i am using yarn)
![Screenshot 2024-04-02 at 7 41 57 AM](https://private-user-images.githubusercontent.com/43492596/318670970-7fc6921e-69e5-4bdb-8ae9-17adc70bfcd8.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMjMxMjAsIm5iZiI6MTcyNDMyMjgyMCwicGF0aCI6Ii80MzQ5MjU5Ni8zMTg2NzA5NzAtN2ZjNjkyMWUtNjllNS00YmRiLThhZTktMTdhZGM3MGJmY2Q4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDEwMzM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU3MGI1NTcwYTliMmZiZjZkNWMyZWFlMzk2YjliZWUwZjQyMjk0NDIxZTEwYTg0YzBkNzczZDc5OTNhMjIxYzEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.jDU7KZN1sJNFy0-sU68McXbJH3A2IPQAUe9_-kpUsz8)
![Screenshot 2024-04-02 at 7 42 36 AM](https://private-user-images.githubusercontent.com/43492596/318671033-807ec9a0-556a-4ae0-9ecb-ecbfff2ef746.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMjMxMjAsIm5iZiI6MTcyNDMyMjgyMCwicGF0aCI6Ii80MzQ5MjU5Ni8zMTg2NzEwMzMtODA3ZWM5YTAtNTU2YS00YWUwLTllY2ItZWNiZmZmMmVmNzQ2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDEwMzM0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU0ODk2NzMwMWQ4YjlhZTRjZDQzMzBkNDA5NTRiMTMwODkwMWY2MDYyNGMyMzRhNjJkOTNhNjFjOGY2MWE3ZmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ygwpis3ukASAJNxbszCoHF8dve8MV0JWPlz8BXI2hAA)
from mailer.
does anyone know why the fix can be released?
from mailer.
I have the same issue
my version:
"@nestjs-modules/mailer": "^1.11.2",
I fixed it this way Path:
node_modules/@nestjs-modules/mailer/dist/mailer.service.js
I changed
then(() => this.mailerLogger.error(
Transporter${transporterName} is ready))
tothen(() => this.mailerLogger.log(
Transporter${transporterName} is ready))
Why can't this be part of a pr and release? Seems trivial, though I haven't spent much time looking into this
from mailer.
This package is not suitable (anymore ?) for production, it has been continuously broken in a way or another for the last two years we've been using it.
No hard feelings for the maintainers who do as much as they can, and thanks for their hard work, but now it's pretty clear everyone using this package for serious matter should look for an alternative.
from mailer.
Is there a process to allow new maintainers ?
from mailer.
please has the problem been resolved?
from mailer.
I didn't pull the latest changes, but I believe it has. I was following a related PR that I believe got merged
from mailer.
the same here
from mailer.
Related Issues (20)
- verifyTransporter function doesn't check if transport.verify is defined
- Error: Cannot find module '@css-inline/css-inline-freebsd-x64' HOT 2
- Is this project alive? HOT 3
- use multiple user and pass for auth in transport
- In search of members for the organization HOT 4
- lib/mailer.service.ts#L23 private to public? HOT 3
- [Bug]: transporter.verify(...).then is not a function was not fixed in 2.0.0 HOT 3
- Error: Cannot find module 'preview-email', in version 2.0.0 HOT 4
- Error: Cannot find module 'preview-email' HOT 10
- MailerService at index [1] is available in the module
- Error: connect ENOENT alt1.gmail-smtp-in.l.google.com HOT 1
- Vulnerability in the 2.0.2 HOT 7
- sendMail attachments error
- Error: Cannot find module '@css-inline/css-inline-linux-arm64-musl when starting application HOT 6
- Send mailgun using nodemailer-mailgun-transport received connect ECONNREFUSED ::1:587
- sendEmail hangs indefinitely after migrating 1.8.1 to 1.9.1+ HOT 1
- EJS/Handlebars/Pug are not really optional Dependencies
- Does it support oauth2 authentication? HOT 1
- ERR_REQUIRE_ESM error when running application inside Docker
- Tslib dependency at runtime
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mailer.