Git Product home page Git Product logo

Comments (9)

nervetattoo avatar nervetattoo commented on September 13, 2024 5

Yeah; I can see how this is very cluttering.
I almost should get myself a more complex thermostat component just to see these cases for myself!

Adding an option is simple enough so I guess I'll be adding one of these flavours for configuration.

hide:
  mode:
    - heat_eco
    - manufacturer_specific

hide:
  mode: false
mode:
  include:
    - on
    - off

from simple-thermostat.

nervetattoo avatar nervetattoo commented on September 13, 2024 3

Thinking through this a little bit more my current intention is to go with the following approach, I'm sharing it first to hear if people think this makes sense.
I will deprecate the hide.mode and instead introduce the modes top level key. modes will be merged with the entity reported modes by default, meaning you can override items there, but you need to explicitly configure each item you want to change, or else it will use the defaults and look like today. I'm on the fence about also allowing to specify it to not merge, mostly because its hard to find a succinct config structure while supporting that in a good way.
Without disabling merging, the only use case that becomes hard is if you want to only include these two sensors out of 7 reported ones

Anyway, here's the planned config:

modes:
  weird_mode: false
  off:
    name: Make it cold
    icon: mdi:whitewalker
  on:
    name: On
    icon: false
    color: <any valid css color>
  wonky_mode:
    include: false

It also supports the shorthand from hide.mode:

modes: true|false

If I decide to allow disabling merging I'm leaning towards a special key in the modes map:

modes:
  _merge: false
  off: true
  on: true

Are there anything you feel is not supported with this? I think it covers all requests and feedback I've heard quite extensively, but just to be sure I want to let this sit here for a day or two before I implement the changes.

from simple-thermostat.

fredrike avatar fredrike commented on September 13, 2024 1

Perhaps the icon mode could be added to the configuration:

mode:
  - type: on
    icon: mdi:on

from simple-thermostat.

KarimGeiger avatar KarimGeiger commented on September 13, 2024 1

Sounds perfect!

As for the disabling of merging, for me personally, this isn't really necessary. I think one can invest the time to adjust the configuration and disable all entities by hand. Of course it would be nice to have, I can imagine, but it's another feature that needs to be supported if it breaks, so I'm not sure if it's worth the trouble. Did you get any requests for that specific feature?

from simple-thermostat.

KarimGeiger avatar KarimGeiger commented on September 13, 2024

I'd really appreciate both of these features. If I could get rid of the "an" mode and add an icon to the "boost" mode, it would be absolutely fantastic!

screenshot 2019-02-26 at 15 18 02

By the way, thanks for the awesome work so far, and also thanks for keeping it up with the development and adding new features. The change from dropdown to buttons looks great πŸ‘

from simple-thermostat.

nervetattoo avatar nervetattoo commented on September 13, 2024

This will happen folks, just be patient as I find the time πŸ—“

from simple-thermostat.

hcoohb avatar hcoohb commented on September 13, 2024

Hi,
Love this card and would love that function to remove some modes from the UI.
To me, the 'merge' part start to gets complicated... whereas listing all your modes to be able to disable some is still acceptable I think.
Thanks a lot

from simple-thermostat.

KarimGeiger avatar KarimGeiger commented on September 13, 2024

Awesome work, thanks!

from simple-thermostat.

github-actions avatar github-actions commented on September 13, 2024

πŸŽ‰ This issue has been resolved in version 1.0.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

from simple-thermostat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.