Git Product home page Git Product logo

Comments (4)

neowit avatar neowit commented on July 17, 2024

There is actually no JSON in the response.
It just so happens that vim dictionary (when serialised) looks like JSON.

These line prefixes like Error: are used (in shell scripts or vim) to grep response file, quickly get relevant lines, and (in vim case) pass it to eval() which converts them to vim dictionary.

Response file format was originally created with vim and shell scripts as its primary clients in mind. Also, at that time vim did not support real JSON parsing (since version 8 it does).

Shell client (e.g. used by CI) usually does not care what exact errors occurred and just needs to “know” if there are any. Here lines prefixed with Error: also come handy.

It is technically not a big deal to add a new output format. It would require new "protocol" implementation (here is vim example) and adding a flag to "--action" instructing it which format to use.

from tooling-force.com.

ChuckJonas avatar ChuckJonas commented on July 17, 2024

nice, I've been wanting to get involved in this project (although I've never written scala), maybe this would be a good place to start when I have some free time.

Also, it must be outputting valid JSON as I haven't had any problems parsing it.

from tooling-force.com.

neowit avatar neowit commented on July 17, 2024

A good start would be to define what the protocol is going to look like first, and think if it will use response file approach or some other way (e.g. stdout or TCP Socket). I do not recommend stdout though because if you want proper JSON then log output will mess it up.

What are you planning to use it with (as a client) ? In another ticket you mentioned Sublime, is this your client in mind ?

from tooling-force.com.

ChuckJonas avatar ChuckJonas commented on July 17, 2024

I've actually already published an extension for vscode that is pretty much just a proxy for this library (but only around language features).

It's starting to pick up traction, especially since I added support for the findSymbol & checkSyntax actions.

The output is fine for now, I just thought this might be a good place to get my feet wet and contribute to your project (because it has no doubt some of the best language features of anything out there).

from tooling-force.com.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.