Git Product home page Git Product logo

Comments (8)

flatcap avatar flatcap commented on September 21, 2024

Ah, sorry. That got overlooked in the upgrade.

Please can you give branch [devel/expando] a try.

Thanks

from neomutt.

kstephan-wescale avatar kstephan-wescale commented on September 21, 2024

Thanks for getting onto it so fast!
It throws a segfault, here’s some gdb output:

@(gdb) run
Thread 1 "neomutt" received signal SIGSEGV, Segmentation fault.
                                                               check_for_pipe (root=<optimized out>) at expando/expando.c:132
132         if (last->start[i] == '\\')
@(gdb) backtrace
#0  check_for_pipe (root=<optimized out>) at expando/expando.c:132
#1  expando_render (exp=<optimized out>, rdata=0x555555709fa0 <SidebarRenderData>, data=0x7fffffffdd10, flags=<optimized out>, max_cols=19, buf=0x555555738450) at expando/expando.c:209
#2  0x0000555555671186 in make_sidebar_entry (buflen=256, shared=0x5555557b2af0, sbe=0x5555559497f0, width=19, buf=0x5555559498f0 "") at sidebar/window.c:593
#3  sb_recalc (win=<optimized out>) at sidebar/window.c:873
#4  0x00005555555f4a6d in window_recalc (win=win@entry=0x555555949aa0) at gui/mutt_window.c:579
#5  0x00005555555f4a88 in window_recalc (win=win@entry=0x5555559453f0) at gui/mutt_window.c:585
#6  0x00005555555f4a88 in window_recalc (win=win@entry=0x55555592e9c0) at gui/mutt_window.c:585
#7  0x00005555555f4a88 in window_recalc (win=win@entry=0x55555592e700) at gui/mutt_window.c:585
#8  0x00005555555fcd0b in window_redraw (win=<optimized out>) at gui/mutt_window.c:642
#9  0x000055555559d3b9 in dlg_index (dlg=<optimized out>, m_init=<optimized out>) at index/dlg_index.c:1243
#10 0x00005555555615f1 in main (argc=<optimized out>, argv=<optimized out>, envp=<optimized out>) at /usr/src/debug/neomutt-git/neomutt/main.c:1430

from neomutt.

flatcap avatar flatcap commented on September 21, 2024

Thanks for the backtrace; very helpful.
Turns out I'm an idiot :-)
When working backwards through a string, don't use ++

Please can you give the [devel/expando] branch another try.
It's working robustly now (and has some tests, too)

Thanks!

from neomutt.

kstephan-wescale avatar kstephan-wescale commented on September 21, 2024

It works like a charm. Thanks a ton for your work!

from neomutt.

flatcap avatar flatcap commented on September 21, 2024

Brilliant! Thanks!

from neomutt.

elpeh avatar elpeh commented on September 21, 2024

Hello, continuing...: 202404125 leads to calling the external filter program for (index, in this case) format string.
BUT: documentation states: "30.3 Filters [...] If the returned string ends in %, it will be passed through the formatter a second time. This allows the filter to generate a replacement format string including % expandos. [...]"
This reevaluation is not happening, generated format string value is printed in index literally (in contrast to 20240416 and earlier).

from neomutt.

flatcap avatar flatcap commented on September 21, 2024

Well spotted, @elpeh.
I'm working on it.

from neomutt.

elpeh avatar elpeh commented on September 21, 2024

Thanks. As my setup is quite old, I'll meanwhile try to replace all/most using the index-format-hook feature.

from neomutt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.