Comments (6)
roman-khimov
commented on July 19, 2024
1
I've never seen it being used, NeoGo never supported it (and no one ever requested it), so if it doesn't work anyway, it can be safely removed.
from neo.
Ashuaidehao
commented on July 19, 2024
After some test, Akka's context couldn't use in aysnc/await directly, it will throw an exception of There is no active ActorContext, this is most likely due to use of async operations from within this actor. in this line.
neo/src/Neo/Network/P2P/Peer.cs
Line 396 in 254fc99
So our websocket channel has never been enabled.
Since we have TCP channels for P2P message forword, the websocket channels looks no use any more.
from neo.
cschuchardt88
commented on July 19, 2024
If you remove it, than maybe we can convert to dotnet standard 2.1. The main reason why we couldn't do this, is because of the asp.net core part.
Does that mean we are not fixing or removing it?
from neo.
vncoelho
commented on July 19, 2024
Perhaps Akka has its internal mailbox, if the rest can be removed it would be a good move.
from neo.
Jim8y
commented on July 19, 2024
Wait a minute, if we support it, will it improve the performance?
from neo.
cschuchardt88
commented on July 19, 2024
Wait a minute, if we support it, will it improve the performance?
No, If anything it will slow the node down. All you have is same number of connections. Just split up unevenly on different ports.
from neo.
Related Issues (20)
- [Neo Core Event] Define Interfaces for Core Event Handlers
- Comments for Tarjan class HOT 2
- Quality of life CLI options --config-file & --ignore-plugin-network HOT 4
- Add Unit Tests for RpcServer Plugin
- dotnet publish doesn't work in plugin's project path HOT 4
- Wrong debug/release path of plugins HOT 3
- RpcServer Unit Tests: Node
- Leveldb exception handle HOT 26
- version error 1.0.0 HOT 1
- Allow list of AnomalyTransaction types vs Explicit Hardfork HOT 1
- Should native contracts be destroyable? HOT 2
- Work on a DEV branch.
- List Plugins Display Showing Wrong Files HOT 3
- Extend applicationlogs with invocations HOT 11
- Extend `Designated` native RoleManagement events with old/new public keys
- Extend `getversion` RPC response with additional protocol settings HOT 5
- Add support to verify message without hashing HOT 2
- RockDb FileNotFoundException HOT 3
- Exception handle mechanism for Plugins/Modules HOT 2
- Improve session mechanism HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from neo.