System_Runtime_CurrentSigners `LInq` ArgumentNullException in ApplicationEngine about neo HOT 9 CLOSED

IIUC this never happens for real (deserialized) transactions, so not that big of an issue:

But maybe worth fixing for tests.

from neo.

@cschuchardt88, congratulations for the recent finding and dedication to the project.

I saw your comment but later you deleted it. It was about a dynamic script.
Were you able to verify something related to that?

from neo.

No, all the information is in the 1st comment. It just crashes the vm.

from neo.

It will be solved changing neo to nullable

from neo.

What is the problem is. If you call syscall CurrentSigners. It fails in dynamic scripts. Because the transaction isn't being deserialized soon enough even though you are passing in a transaction.

from neo.

@shargon @Jim8y

This needs to be fixed take for example:

neo> invoke 0x598afeea6a97e87f69d10d55047f459cf6917656 test
Invoking script with: 'wh8MBWRyYWluDBRWdpH2nEV/BFUN0Wl/6Jdq6v6KWUFifVtS'
VM State: FAULT
Gas Consumed: 0.0098655
Result Stack: []
Error: Value cannot be null. (Parameter 'source')

[DisplayName(nameof(TestContract))]
[ContractPermission("*", "*")]
public class TestContract : SmartContract
{
    [Syscall("System.Runtime.CurrentSigners")]
    public static extern Signer[] GetSigners();


    public static void Test()
    {
        try
        {
            var signers = GetSigners();
        }
        catch
        {
        }
    }
}

from neo.

@shargon @Jim8y

This needs to be fixed take for example:

neo> invoke 0x598afeea6a97e87f69d10d55047f459cf6917656 test
Invoking script with: 'wh8MBWRyYWluDBRWdpH2nEV/BFUN0Wl/6Jdq6v6KWUFifVtS'
VM State: FAULT
Gas Consumed: 0.0098655
Result Stack: []
Error: Value cannot be null. (Parameter 'source')

[DisplayName(nameof(TestContract))]
[ContractPermission("*", "*")]
public class TestContract : SmartContract
{
    [Syscall("System.Runtime.CurrentSigners")]
    public static extern Signer[] GetSigners();


    public static void Test()
    {
        try
        {
            var signers = GetSigners();
        }
        catch
        {
        }
    }
}

If this tx @cschuchardt88 is failing, perhaps it need a HF.

from neo.

@vncoelho

No its just the Transaction isn't getting passed as a parameter to the ApplicationEngine only the script is or Signers are null; for invoking contract methods in the CLI.

from neo.

@vncoelho

No its just the Transaction isn't getting passed as a parameter to the ApplicationEngine only the script is or Signers are null; for invoking contract methods in the CLI.

I see, I will reproduce here.

from neo.