Comments (4)
wbhart
commented on May 31, 2024
I guess this is intended to be used to construct the ideal set parent object for a given ring. But we should export such a function to the user from Oscar.jl rather than AbstractAlgebra.jl. That would then call the individual constructors in the various packages, rather than just import and export them. So I think I will remove the function in AbstractAlgebra.jl.
from abstractalgebra.jl.
fieker
commented on May 31, 2024
On Fri, Apr 27, 2018 at 03:53:00AM -0700, wbhart wrote:
I guess this is intended to be used to construct the ideal set parent object for a given ring. But we should export such a function to the user from Oscar.jl rather than AbstractAlgebra.jl. That would then call the individual constructors in the various packages, rather than just import and export them. So I think I will remove the function in Nemo.jl.
So every package has to define a not exported function IdealSet that
will be called from Oscar?
Or should Oscar do
IdealSet(R::RingOfAbstractAlgebra) = AA.IdealSet(R)
or
IdealSet(R::RingOfAbstractAlgebra) = AAIdealSet(R)
and so on:
IdealSet(R::RingOfNemo) = Nemo.IdealSet(R)
IdealSet(R::RingOfHecke) = Hecke.IdealSet(R)
I can see that it is much easier to remove it from AA, but I think in
the long run, it will be renamed in Singular...
… --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#84 (comment)
from abstractalgebra.jl.
wbhart
commented on May 31, 2024
The problem isn't that they export the function IdealSet. They can do this just fine.
The problem is the intention of having a function in AA that can be overloaded by other packages. This doesn't work for things that could be constructing concrete types of the same name.
The intention of exporting it from AA is that other packages will import it. But Singular.jl would not do so, for example, because of the conflict with its own type of that name. So that kind of defeats the purpose of having it in the first place.
I would definitely expect that in the very long run, AA would itself define an IdealSet function which allows the definition of ideal sets for certain (very limited) ideals that it can construct. But the intention wouldn't be that other packages import this, since they probably do something much more sophisticated.
The principal of exporting dummy functions from AA that other packages can import and extend is actually fine. It just can't be done for things that might be types (with capital letters), unless the intention is that other packages NOT import them from AA.
from abstractalgebra.jl.
wbhart
commented on May 31, 2024
What I'm saying is that the other solution here is that I don't import IdealSet from AA in Singular.jl. But this demonstrates why it's a bad idea to define it with the intention of it being imported, because it just won't be in practice. It's fine to define it with the intention of it not being imported, as with many things with capital letters defined in AA.
from abstractalgebra.jl.
Related Issues (20)
- How to convert an univariate polynomial to a multivariate polynomial? HOT 2
- `minpoly` `MethodError` HOT 2
- docs: duplicate entry for `evaluate`
- Missing or incomplete docstrings for various ring constructors
- `vars` for fractions of multivariate polynomials HOT 1
- New polynomial ring constructor implementation is type unstable
- [Bug] `view` only likes `UnitRange` even though it accepts other arguments HOT 6
- Loading this package breacks `show(Union{}[])` HOT 4
- `is_[lower/upper]_triangular` not useful for non-square matrices HOT 5
- The use of polynomial rings in multi-threaded programs HOT 3
- Rename `intersection` methods to `intersect`
- Try to export `Generic` HOT 1
- Pretty printing code (esp. indent) has issues with non-ASCII unicode strings HOT 6
- Should `macro show_name` / `@show_name` check for `:supercompact` in addition to `:compact` ? HOT 2
- Missing `Lowercase` in some printing functions HOT 2
- Implement `algebraic_closure(QQ)`
- Add a variant of `allow_unicode` which does not modify `LocalPreferences.toml` and only enables/disables unicode for the current session
- Invalidations caused by `lock(io::IOCustom)` HOT 2
- Documentation of aliases seems to fail on nightly? HOT 3
- Typo in incompatible rational function field error message
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abstractalgebra.jl.