Git Product home page Git Product logo

Comments (12)

wbhart avatar wbhart commented on May 29, 2024

Perhaps @kalmarek could look into adding a Group interface to the docs, modeled after the Ring interface.

The factoring out of the common part can be done later on, if we decide we want it.

from abstractalgebra.jl.

wbhart avatar wbhart commented on May 29, 2024

Fixed in trunk.

from abstractalgebra.jl.

kalmarek avatar kalmarek commented on May 29, 2024

where is the group interface actually described?

from abstractalgebra.jl.

wbhart avatar wbhart commented on May 29, 2024

I'll reopen if you like.

from abstractalgebra.jl.

kalmarek avatar kalmarek commented on May 29, 2024

I was just curious if something was done what slipped my attention

from abstractalgebra.jl.

wbhart avatar wbhart commented on May 29, 2024

No, nothing. I just looked and saw there was a section "Groups" in the docs. I didn't check carefully enough.

By the way, would you be terribly offended if we based the Groups section of Oscar.jl on Gap instead of your Julia code in AbstractAlgebra? (The latter can continue to exist and will be independently useful, in my opinion, it just wouldn't be the default code for groups in Oscar.jl.) Basically Oscar.jl has to make a canonical choice between all the different systems for each type of object, and then implement conversions to all the others.

from abstractalgebra.jl.

kalmarek avatar kalmarek commented on May 29, 2024

No, not at all ;-)

from abstractalgebra.jl.

wbhart avatar wbhart commented on May 29, 2024

I think we are not going to spend much time implementing Groups in AbstractAlgebra, or defining a full interface. Of course this may be revisited at some point.

But for now I will mark this as something the Julia community might like to take over, if it is useful to them.

from abstractalgebra.jl.

kalmarek avatar kalmarek commented on May 29, 2024

Such interface is already defined in GroupsCore.jl package.

If AbstractAlgebra won't implement anything more on the groups side it would make more sense for GroupsCore to define Group abstract type, since then could be extended by "julia_community" (e.g. become a subtype of Monoid etc).

Of course only if Oscar.jl intends to implement GroupsCore interface for its groups @fingolfin?

from abstractalgebra.jl.

wbhart avatar wbhart commented on May 29, 2024

Ok with me. We only use permutations I believe. I don't see any way around continuing to do so. But yeah, there is no need for us to define Group if that is more convenient.

from abstractalgebra.jl.

thofma avatar thofma commented on May 29, 2024

Hecke uses Group for the abelian groups. Alternatively the group Interface stuff just goes here without further discussions.

from abstractalgebra.jl.

wbhart avatar wbhart commented on May 29, 2024

Ok, I'll mark this as decision instead of julia_community. I don't have an opinion and will wait for you guys to decide what you want. I am not a computational group theorist. :-)

from abstractalgebra.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.