Comments (7)
wbhart
commented on May 29, 2024
That would not be possible without copying the data. I am not sure if that
is the current behaviour of sub. @thofma might have some insight into this.
from abstractalgebra.jl.
wbhart
commented on May 29, 2024
Actually, I might have spoken too hastily here. If there was a new type for
such submatrices, it could overload its own setindex! and getindex to look
up which entry in the original matrix to modify.
There are limitations on what we can do, however, due to the fact that our
matrices are (necessarily) different to Julia matrices.
from abstractalgebra.jl.
wbhart
commented on May 29, 2024
By the way, you can do the following:
N = matrix(ZZ, 3, 3, [1, 2, 3, 4, 5, 6, 7, 8, 9])
P = matrix(ZZ, 2, 2, [N[i, j] for i in [1, 3] for j in [2, 3]])
…from abstractalgebra.jl.
heiderich
commented on May 29, 2024
Yes, of course. This is merely a convenience function.
The function sub(M::AbstractAlgebra.MatElem, rows::UnitRange{Int}, cols::UnitRange{Int}), which is called by sub(M::AbstractAlgebra.MatElem, r1::Int, c1::Int, r2::Int, c2::Int) uses deepcopy for the coefficients. I thought about doing just the same.
from abstractalgebra.jl.
wbhart
commented on May 29, 2024
Ok, I wasn't aware of that. If Tommy is ok with it, then sure, go ahead.
from abstractalgebra.jl.
thofma
commented on May 29, 2024
Makes sense to add it (in AbstractAlgebra).
One minor downside is that we won't have a corresponding version for view but this should not stop us.
from abstractalgebra.jl.
heiderich
commented on May 29, 2024
See #121.
from abstractalgebra.jl.
Related Issues (20)
- How to convert an univariate polynomial to a multivariate polynomial? HOT 2
- `minpoly` `MethodError` HOT 2
- docs: duplicate entry for `evaluate`
- Missing or incomplete docstrings for various ring constructors
- `vars` for fractions of multivariate polynomials HOT 1
- New polynomial ring constructor implementation is type unstable
- [Bug] `view` only likes `UnitRange` even though it accepts other arguments HOT 6
- Loading this package breacks `show(Union{}[])` HOT 4
- `is_[lower/upper]_triangular` not useful for non-square matrices HOT 5
- The use of polynomial rings in multi-threaded programs HOT 3
- Rename `intersection` methods to `intersect`
- Try to export `Generic` HOT 1
- Pretty printing code (esp. indent) has issues with non-ASCII unicode strings HOT 6
- Should `macro show_name` / `@show_name` check for `:supercompact` in addition to `:compact` ? HOT 2
- Missing `Lowercase` in some printing functions HOT 2
- Implement `algebraic_closure(QQ)`
- Add a variant of `allow_unicode` which does not modify `LocalPreferences.toml` and only enables/disables unicode for the current session
- Invalidations caused by `lock(io::IOCustom)` HOT 2
- Documentation of aliases seems to fail on nightly? HOT 3
- Typo in incompatible rational function field error message
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abstractalgebra.jl.