Comments (9)
wbhart
commented on May 31, 2024
No, but this should/will be changed. I think we already accepted a pull
request to only allow nvars to apply to the ring (or one was proposed).
from abstractalgebra.jl.
heiderich
commented on May 31, 2024
Actually I think it might also be helpful to have a function that returns all variables appearing in a polynomial. I thought about returning it as a Set rather than an Array. While testing this, I encountered #111.
from abstractalgebra.jl.
wbhart
commented on May 31, 2024
I am not super keen to use sets for this. Whilst it makes for a nice syntax
for checking whether something is in the set, a more programmatically
relevant problem might be to iterate over those variables. Sets aren't the
best structure for that.
from abstractalgebra.jl.
heiderich
commented on May 31, 2024
If returning them as an Array, I think we should specify the order of its elements. How can the generators be compared? I guess one could use the monomial_isless functions, but they do not take MPolys as arguments. Is there already a way to easily compare monomials (the actual MPoly objects)?
from abstractalgebra.jl.
wbhart
commented on May 31, 2024
No, there is no interface for dealing with this yet, as there is no
interface for dealing with monomials, as currently, things are not
implemented correctly (terms and monomials are both stored in the wrong
order compared to the way it is done in Flint).
But in general, I agree they should be returned in an order that doesn't
surprise the user, e.g. the order the user originally specified.
from abstractalgebra.jl.
heiderich
commented on May 31, 2024
I could return them as an array in arbitrary order for the moment and we could change the order once we can compare monomials. What do you think about that?
from abstractalgebra.jl.
wbhart
commented on May 31, 2024
It should be possible to return them in the order they are currently stored
in exponents, and then check this is the same as the order returned by the
gens function (rather than the reverse order).
from abstractalgebra.jl.
heiderich
commented on May 31, 2024
See PR #114. I however do not check whether the order is the same as the one returned by the gens function. What should happen if this is not the case?
from abstractalgebra.jl.
wbhart
commented on May 31, 2024
I don't mean the code should check this. I just mean that the user is
likely going to expect that, and it shouldn't be hard for us to try a few
examples and check that this is actually the case.
But let me look at your code first. Things are slightly hectic at the
moment, so it may take me a few days.
from abstractalgebra.jl.
Related Issues (20)
- Pretty printing code (esp. indent) has issues with non-ASCII unicode strings HOT 6
- Should `macro show_name` / `@show_name` check for `:supercompact` in addition to `:compact` ? HOT 2
- Missing `Lowercase` in some printing functions HOT 2
- Implement `algebraic_closure(QQ)`
- Add a variant of `allow_unicode` which does not modify `LocalPreferences.toml` and only enables/disables unicode for the current session
- Invalidations caused by `lock(io::IOCustom)` HOT 2
- Documentation of aliases seems to fail on nightly? HOT 3
- Typo in incompatible rational function field error message
- Rename `UniversalPolynomialRing` to `universal_polynomial_ring`
- `@polynomial_ring` is broken for coefficient rings not in `AbstractAlgebra`. HOT 1
- `@polynomial_ring` support for key-value pairs is broken
- Add matrix conjugation method
- An example of bad behaviour of multivariate gcd HOT 4
- Methods for finding factors and roots of a polynomial in AbstractAlgebra.jl HOT 3
- Issues with `normalise` for polynomials.
- Make the GF function thread-safe HOT 4
- Use `WeakKeyIdDicts.jl` HOT 4
- Add conformance tests for `Generic.SparsePoly` HOT 1
- Add conformance tests for `Generic.FunctionField` / fix bugs this reveals HOT 1
- Move banner hiding code to a separate package? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abstractalgebra.jl.