[Symfony3] Wrong with log external Redirect about nelmiosecuritybundle HOT 4 CLOSED

The LoggerInterface is deprecated since Symfony 2.2 but it's possible there are still packages out there that are using this interface (and this bundle still supports Symfony 2.3).

So instead of updating the typehint, it should be removed and we need check if eg. an instance of Psr\Log\LoggerInterface or Symfony\Component\HttpKernel\Log\LoggerInterface is provided.

There is only one one line where the logger is used: https://github.com/nelmio/NelmioSecurityBundle/blob/master/EventListener/ExternalRedirectListener.php#L81 and this needs to check which interface is used (at least until support for Symfony 2.x is dropped).

from nelmiosecuritybundle.

@VuiLenDi for now (totally temporarily) you may use my repository:

https://github.com/gencer/nelmio-symfony3

$ compose require "gencer/nelmio-symfony3"

from nelmiosecuritybundle.

Should be fixed now, I just migrated to PSR-3 logger because frankly 2.2 is very old, and this would only affect someone implementing their own logger against this outdated interface, while most people use monolog as it's been shipping with symfony2 since day one. I think it's safe enough and if not it should be easy for people to upgrade anyway.

from nelmiosecuritybundle.

Thanks @Seldaek

from nelmiosecuritybundle.