Git Product home page Git Product logo

Comments (3)

Seldaek avatar Seldaek commented on June 7, 2024

Yes either that or we just outright remove it as discussed in #24, because I guess strictly speaking it's not the bundle's job to enforce that non-OPTIONS requests with an Origin header come from an allowed origin. CORS client implementations should prevent those requests to happen if the OPTIONS request failed.

from nelmiocorsbundle.

marcoleong avatar marcoleong commented on June 7, 2024

I agree that we can just remove it. It is not specified in the recommendation.
And this bundle is mean to provide basic CORS headers only. Access denied check shall be done by other bundle that have access to the resources itself.

from nelmiocorsbundle.

Seldaek avatar Seldaek commented on June 7, 2024

1.3.2 is now released, with the "fix" included.

from nelmiocorsbundle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.