Git Product home page Git Product logo

Comments (6)

mabod avatar mabod commented on June 3, 2024 1

From my point of view it can be closed. Thank you!
But can you share a link to the systemd PR here?

from systemd-swap.

vilgotf avatar vilgotf commented on June 3, 2024

First thing, you should always use only one zram device since there's no performance improvement from having multiple (this should be documented). Secondly I'd recommend systemd/zram-generator if you only use zram (should also be documented).

I'll keep this issue in mind, but don't expect any patches soon.

from systemd-swap.

mabod avatar mabod commented on June 3, 2024

First thing, you should always use only one zram device since there's no performance improvement from having multiple (this should be documented).

That is interesting because the default behavior is actually that it creates ${NCPU} zram devices. I just tested it by commenting the zram_count in the config file. Shouldnt the default then be just one zram device?

And it does not explain where the dependency to dbus-broker is coming from: 49 s without dbus-broker compared to 4 s with dbus-broker is a big difference.

from systemd-swap.

HidingCherry avatar HidingCherry commented on June 3, 2024

Please read this:
https://www.kernel.org/doc/html/latest/admin-guide/blockdev/zram.html#set-max-number-of-compression-streams

Since we have multiple streams per zram device - there is no use to have multiple zram devices.
An exception might be with multiple NUMA devices? Although - I don't know if the kernel takes this into account.

from systemd-swap.

polarathene avatar polarathene commented on June 3, 2024

The referenced systemd issue got resolved, bug was identified as something missed during 2016 commit. PR was merged recently for upcoming v251 release of systemd.

dbus-broker avoided the issue as it doesn't try to do some logic that dbus-daemon was doing (which IIRC was timing out from a deadlock or something like that), dbus-daemon also queues messages differently I think, so your experience with multiple devices vs single was likely related to behaviour with that?

Should be safe to close issue? (unless you want to wait for v251 release and broader availability)

from systemd-swap.

polarathene avatar polarathene commented on June 3, 2024

can you share a link to the systemd PR here?

systemd/systemd#22552

from systemd-swap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.