Comments (12)
from pingnoo.
Awesome. I think it would also require an extra step when every version is released to tell brew about the new version.
Brew is traditionally for command line applications and then they call regular applications "casks". I'm used to installing (and updating) most of my free software through brew. Makes it easy to track updates across my whole system.
from pingnoo.
from pingnoo.
Ok, I submitted a PR to add the cask Homebrew/homebrew-cask#120000
To update, the version parameter in the Casks/pingnoo.rb
file in the homebrew-cask repo needs to be updated and then the new sha256
value for the new .dmg
file also updated. I'm not really sure how you would automate this process within your teamcity process as I'm not familiar with it. Is that something you could look into (assuming that the cask is accepted)?
Also, I assumed that the "latest" version is the one tagged "Latest" on GitHub and not what the website downloads. I setup a version check in the cask file based on that assumption also. #96
from pingnoo.
from pingnoo.
Sorry to hear you've been unwell.
Let's see if brew accept the cask. It should be fairly easy to document how to update the cask, but the method requires opening a PR on GitHub, so I guess that it's probably easier to do it manually rather than try and script it.
from pingnoo.
Some feedback on the PR, we're hitting an issue with the versioning, not sure what the solution will be, but will report back.
from pingnoo.
Okay, I think everything has been sorted out and the PR should land. So that'll put the current "Latest" version from GitHub into brew. In theory, to release a new version to homebrew, you'll need to open a Pull Request against the homebrew-cask
repo which updates the version
and sha256
values in the Casks/pingnoo.rb
file. I'd assume that it's simpler to do that by hand than it is to automate it, especially the part about opening a PR, I guess that's hard to script. What do you think?
from pingnoo.
from pingnoo.
Fair enough, totally up to you.
I think the steps are:
- Fork the homebrew-cask repo
- Create a new branch
- Update the
version
andsha256
values inCasks/pingnoo.rb
version
gets the latest version stringsha256
gets the sha256 value of the.dmg
file
- Commit
- Create a pull request
The pull request has a format, and there's a series of tasks which should be completed. Like running brew audit
and other commands. But there's also a load of checks run when you open the PR. I'm not sure how you'd want to approach that, whether you run all those tasks and then update the PR body, or write some code to check that the tasks haven't changed, etc. Here's the current text of the new PR template:
**Important:** *Do not tick a checkbox if you haven’t performed its action.* Honesty is indispensable for a smooth review process.
_In the following questions `<cask>` is the token of the cask you're submitting._
After making all changes to a cask, verify:
- [ ] The submission is for [a stable version](https://docs.brew.sh/Acceptable-Casks#stable-versions) or [documented exception](https://docs.brew.sh/Acceptable-Casks#but-there-is-no-stable-version).
- [ ] `brew audit --cask <cask>` is error-free.
- [ ] `brew style --fix <cask>` reports no offenses.
Additionally, **if adding a new cask**:
- [ ] Named the cask according to the [token reference](https://docs.brew.sh/Cask-Cookbook#token-reference).
- [ ] Checked the cask was not [already refused](https://github.com/Homebrew/homebrew-cask/search?q=is%3Aclosed&type=Issues).
- [ ] Checked the cask is submitted to [the correct repo](https://docs.brew.sh/Acceptable-Casks#finding-a-home-for-your-cask).
- [ ] `brew audit --new-cask <cask>` worked successfully.
- [ ] `brew install --cask <cask>` worked successfully.
- [ ] `brew uninstall --cask <cask>` worked successfully.
from pingnoo.
from pingnoo.
Btw, I just saw a PR which said "Created with brew bump-formula-pr
.", so maybe the tooling already exists to automate this...
from pingnoo.
Related Issues (20)
- Crash when tab is closed during ping HOT 1
- Website SEC_ERROR_UNKNOWN_ISSUER HOT 1
- IP address reversed on Windows 10 using ICMPAPI engine. HOT 4
- Headless / CMD interface HOT 1
- Final target host is not show in list/graphs HOT 5
- Commit not pushed to Theme Support?
- Brew version cosmetic bug - message "Select new target" shows only when moving div bar? HOT 1
- UDP ping support
- Discrepancy with normal ping or gping command? HOT 1
- Windows service
- long duration of discovery during new trace
- Is this project dead? HOT 11
- macOS Homebrew version crashes on launch on ARM macs HOT 1
- Slight bug with Host # 10 while scanning yandex.ru HOT 2
- cmake3.21 compile error HOT 2
- Enhancement: Overview of results HOT 3
- Website links to latest dev release HOT 5
- Raspberry Pi install failure HOT 1
- Issue with ping interval on windows HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pingnoo.