Git Product home page Git Product logo

Comments (1)

DavidVorick avatar DavidVorick commented on August 12, 2024

I am working on the wallet code and will handle this.

The wallet code has changed in a very, very substantial way. It's been tough to design and we ended up with more features than we needed, but most of them were by consequence of already needing other things.

  • Calling CoinAddress() will give you a new coin address every time. The wallet will be able to remember which outputs belong to it.
  • Calling FreezeCoins() (now renamed AddTimelockedRefund()) will remember how to spend the coins and add them back to the balance once the timelock runs out. FreezeCoins will also generate it's own keypair, unique from all the others to help with privacy a bit.
  • Wallet no longer needs a State, it just needs a list of blocks that have been added and removed since the last call. This does mean that there's some redundant storage in the outputs, but it should be pretty minimal because the Wallet will only be storing outputs that it understands how to spend
  • All mutexes for the wallet are handled internally, no need to ask for mutexes on the wallet.
  • wallet complexity has gone up a substantial amount. There's a chain of really heavily nested for loops (for blocks; for transactions; for inputs & outputs;).

But from a cryptographic perspective, our new wallet is actually moderately passable as a secure thing, whereas before I don't think it could be considered that.

from sia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.