Code Reorganization about sia HOT 6 CLOSED

I guess I also don't know where CatchUp would go. And bootstrapping. Does that get it's own file? Does it go in genesis.go? Do we merge genesis.go and bootstrap.go into a single file named 'synchronizingwiththenetwork.go'?

Also it feels like encoding.go, signatures.go, hash.go, erasure.go all really don't belong in this package. Seems like they more belong as libraries.

Also don't know where the proof of storage stuff would go. In hash.go? In it's own file? Does it join a library with the rest of the files? Also, each of those files should probably be in a separate library, instead of all being in one larger library.

from sia.

Are the dividers supposed to indicate separate packages, or what?

My thoughts:

• erasure.go should live alongside the client code. It's purely a layer on top of the actual protocol.
• I support merging genesis and bootstrap into synchronize.go. CatchUp goes here.
• Definitely support splitting verify.go into txns, blocks, contracts.
• It feels a bit silly to have separate packages for encoding, hash, etc. when they're only one file. But perhaps they'll grow, or we'll have an excuse to separate them into multiple files. So I'm okay with it.
• Proof of storage is tricky. I think it either belongs in its own file, or with contracts.go if it isn't too long already.
• The network code is kind of intermingled with the State code right now. I'd like to untangle them, maybe by creating a Client type that contains both, or something similar. This would mean synchronize.go belongs with the client, not the protocol.

from sia.

Just ran make test and found out I broke sia_test.go by not initializing the State's TCPServer. Definitely leaning towards separating them.

from sia.

proof of storage I feel would go in the same package as the merkle tree stuff. So hash.go in the monolithic model.

from sia.

Should network be its own package?

from sia.

yes. I guess you could shove it all into the client, but I don't think that makes a lot of sense. It forces any client author to write all the network code too.

from sia.