Git Product home page Git Product logo

Comments (3)

nebbian avatar nebbian commented on September 23, 2024

I think we should follow DRY principles as much as possible, which means making everything as generic as possible, and only overriding things that are actually different for each slicer.

I believe that abstract classes can have methods (and code inside those methods), so I'd prefer to put as much code as possible inside the parent "Slicer" class. It might take some clever thought to work out where the line should be drawn between the parent class and the children.

from roboxslicerextension.

natdan avatar natdan commented on September 23, 2024

Go for it. And let us not being afraid refactoring if we think of a better way! :)

from roboxslicerextension.

Benraay avatar Benraay commented on September 23, 2024

ok good news I love DRY code, I will move my code to the parent.

from roboxslicerextension.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.