Comments (3)
I think we should follow DRY principles as much as possible, which means making everything as generic as possible, and only overriding things that are actually different for each slicer.
I believe that abstract classes can have methods (and code inside those methods), so I'd prefer to put as much code as possible inside the parent "Slicer" class. It might take some clever thought to work out where the line should be drawn between the parent class and the children.
from roboxslicerextension.
Go for it. And let us not being afraid refactoring if we think of a better way! :)
from roboxslicerextension.
ok good news I love DRY code, I will move my code to the parent.
from roboxslicerextension.
Related Issues (20)
- Replacing big if else with regular expressions HOT 28
- gcode not working with last version HOT 7
- Installer and control window HOT 59
- Control window doesn't remember choice HOT 2
- Default Cura slicing is broken HOT 4
- Beta testers HOT 7
- Windows Compatibility HOT 56
- Use AM settings HOT 5
- Add path to Slic3r in config window
- Updating the java binaries HOT 1
- Java Flow Windows commissioning
- Windows installer issues HOT 3
- Windows beta testing HOT 29
- Installer might not be updating flow .jar HOT 1
- Linux support HOT 8
- Cura 2.7 support HOT 27
- Cura 3 is available
- rbx-toolset HOT 3
- Merged cura2.7-support to master and setup github as maven repo
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roboxslicerextension.