Comments (4)
frol
commented on July 18, 2024
@evgenykuzyakov Seems to be caused by the same fact of poor communication around safety of is_u8 as in #18 (comment)
from borsh-rs.
evgenykuzyakov
commented on July 18, 2024
Yeah, reimplementing is_u8 has to be marked unsafe.
from borsh-rs.
evgenykuzyakov
commented on July 18, 2024
Ideally we would not even export it, but I'm not sure how to implement it. Basically, is_u8 only for u8 type, but Rust is not very flexible.
from borsh-rs.
dtolnay
commented on July 18, 2024
I think that fix is still wrong.
from borsh-rs.
Related Issues (20)
- FR: Provide a way to borrow data from a slice. HOT 4
- Enum discriminant is not serialized when specified HOT 1
- Adding Async support HOT 14
- Introduce a required `#[borsh(use_discriminant = true|false)]` enum attribute when discriminants are specified HOT 4
- Introduce snapshot testing for all the serialized results HOT 1
- Document borsh crate features HOT 1
- create minimal benches for sets/maps
- `BorshSerialize` failure to compile derive with `#[borsh_skip]` on struct variant field HOT 1
- `insta` tests for prettified `TokenStream`-s in `borsh*derive-internal`
- More than 256 enum variants HOT 2
- Support for serde::{Serialize, Deserialize} HOT 7
- Add a test or two on `#[borsh_init(init)]` logic
- Update near/near-abi-rs to work with alpha release
- Update zeropoolnetwork/bn to work with alpha release HOT 1
- BorshSchema vs custom serialisation HOT 4
- Include discriminant number in `BorshSchema::Enum::variants`
- Rename declarations (tuples, `nil`, `string`, `nonzero_xx` and arrays) HOT 5
- add implementation for `BorshSerialize`, `BorshDeserialize`, `BorshSchema` for `char` HOT 3
- Security Policy violation Branch Protection HOT 2
- Security Policy violation SECURITY.md HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
đ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. đđđ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google â¤ī¸ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from borsh-rs.