Bug: Up and down keys are captured by the VueCommand about vue-command HOT 7 CLOSED

Hi,

First of all thanks for the project, it saves me a lot of time.

Thanks a lot :) Curious how you use the library.

Here you add listeners for the up and down keys and prevent the default behavior. Because of this, the nano editor cannot use the up and down keys

Very good point. Basically most of arrow key inputs are not available and that's not correct!

Im thinking of removing the prevent modifiers and add event.preventDefault() in the increaseHistory and decreaseHistory methods. So that you can disable the history when the nano editor is started. What do you think?

Yeah, that's the way to go. Maybe like this:

increaseHistory (event) {
  if (this.disableHistory || this.isInProgress) {
    return
  }

  event.preventDefault()
}

isInProgress is true when a command executing, which would be the case if the Nano editor has been started.

from vue-command.

Thanks a lot :) Curious how you use the library.

For my personal website.

Very good point. Basically most of arrow key inputs are not available and that's not correct!

What do you mean?

from vue-command.

It seems that this issue will be fixed by #146.

from vue-command.

For my personal website.

I like it! Feels super native in full screen 💪

What do you mean?

I just meant that every application that uses my library cannot assign the arrow keys because it's overwritten by the library. Just wanted to underline it's definitely a bug!

It seems that this issue will be fixed by #146.

Ah no, I close it right away. I tried around but wasn't happy with the final API design. Your PR is welcome :)

from vue-command.

@WitteStier does the problem still persist? If yes, I'll reopen the issue.

from vue-command.

Hi,

Yes the problem is still there. I also found another related bug, if you open the nano editor and press Ctrl + r, the search command will be opened and closes the nano editor. So i created a PR to prevent the default events when the last command is still in progress.

from vue-command.

🎉 This issue has been resolved in version 21.0.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from vue-command.